linux-kernel - Re: [PATCH] tty: Convert from tasklet to BH workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMdWS+fq=hW0MpcCKYrJ5tYHBqVDPRu85cfpH215RwJWQz_HQ@mail.gmail.com>
Date: Tue, 9 Apr 2024 08:48:12 -0700
From: Allen <allen.lkml@...il.com>
To: Jiri Slaby <jirislaby@...nel.org>
Cc: Allen Pais <apais@...ux.microsoft.com>, linux-kernel@...r.kernel.org, tj@...nel.org, 
	keescook@...omium.org, gregkh@...uxfoundation.org, richard.genoud@...il.com, 
	linux-serial@...r.kernel.org
Subject: Re: [PATCH] tty: Convert from tasklet to BH workqueue

> > The only generic interface to execute asynchronously in the BH context is
> > tasklet; however, it's marked deprecated and has some design flaws. To
> > replace tasklets, BH workqueue support was recently added. A BH workqueue
> > behaves similarly to regular workqueues except that the queued work items
> > are executed in the BH context.
> >
> > This patch converts drivers/tty/* from tasklet to BH workqueue.
>
> Quickly looking into the changes, could you also elaborate why not to
> convert most (all?) of them to (non-BH) wq? Or threaded IRQs. Much of
> the code comes from the pre-WQ era.
>

 You are right. The idea I had was to convert every instance of tasklet to
bh workqueues in the kernel. I will send out a v2, which will use
threaded IRQ's.

Thanks.