linux-kernel - Re: [PATCH] usb: misc: onboard_usb_hub: Disable the USB hub clock on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 9 Apr 2024 09:42:43 -0700
From: Matthias Kaehlcke <mka@...omium.org>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Fabio Estevam <festevam@...il.com>, frieder.schrempf@...tron.de, 
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Fabio Estevam <festevam@...x.de>
Subject: Re: [PATCH] usb: misc: onboard_usb_hub: Disable the USB hub clock on failure

On Tue, Apr 9, 2024 at 8:29 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Mon, Apr 08, 2024 at 12:17:00PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@...x.de>
> >
> > In case regulator_bulk_enable() fails, the previously enabled USB hub
> > clock should be disabled.
> >
> > Fix it accordingly.
> >
> > Fixes: 65e62b8a955a ("usb: misc: onboard_usb_hub: Add support for clock input")
> > Signed-off-by: Fabio Estevam <festevam@...x.de>
> > ---
> >  drivers/usb/misc/onboard_usb_dev.c | 6 +++++-
>
> This file is not in the tree for 6.9-rc2, can you please fix this up and
> resend?

The driver has been renamed in usb-next. Shouldn't this patch be based
on usb-next and the backports to stable kernels account for the name
change? v6.9 sits a bit in between, since there is no stable branch
yet. The fix doesn't seem super-critical, I guess it would be ok to
leave v6.9 as is for now and add the fix once there is a stable branch
for it.