[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAL_JsqLJDhJd_uoL05Z=s3Mc7PRkcJWsQGGjdG0Q0GFp0zA8xw@mail.gmail.com>
Date: Tue, 9 Apr 2024 12:26:52 -0500
From: Rob Herring <robh@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
Shengjiu Wang <shengjiu.wang@....com>,
"open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." <linux-sound@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
imx@...ts.linux.dev
Subject: Re: [PATCH v2 1/1] ASoC: dt-bindings: fsl-esai: Convert fsl,esai.txt
to yaml
On Fri, Mar 22, 2024 at 9:54 AM Frank Li <Frank.Li@....com> wrote:
>
> Convert fsl,esai.txt to yaml. So DTB_CHECK tools can verify dts file about
> esai part.
>
> clock-names 'spba' is optional according to description. So minItems of
> clocks and clock-names is 3.
>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>
> Notes:
> Change from v1 to v2
> - alphabetical order compatible string according to rob's suggestion
> - clock description move under 'clock' according to kryszof's suggestion
> - fix descritpion indent according to rob's suggestion
>
> Pass dt_binding check
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,esai.yaml
> DTEX Documentation/devicetree/bindings/sound/fsl,esai.example.dts
> LINT Documentation/devicetree/bindings
> CHKDT Documentation/devicetree/bindings/processed-schema.json
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> DTC_CHK Documentation/devicetree/bindings/sound/fsl,esai.example.dtb
Did you run dtbs_check too? Probably not arm32 at least (first number
is number of warnings):
218 esai@...4000: clocks: [[2, 208], [2, 209], [2, 118], [2,
208], [2, 156]] is too long
218 esai@...4000: clock-names:3: 'spba' was expected
218 esai@...4000: clock-names:2: 'fsys' was expected
218 esai@...4000: clock-names:1: 'extal' was expected
218 esai@...4000: clock-names: ['core', 'mem', 'extal', 'fsys',
'spba'] is too long
Conversions can leave warnings, but any you think should be fixed in
the binding should be fixed in the conversion.
Rob
Powered by blists - more mailing lists