linux-kernel - Re: [EXT] [PATCH v8 3/6] KEYS: trusted: Introduce NXP DCP-backed trusted keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c6164e5-bcfd-4172-a76e-db989f729a8a@pengutronix.de>
Date: Tue, 9 Apr 2024 19:27:44 +0200
From: Ahmad Fatoum <a.fatoum@...gutronix.de>
To: Kshitiz Varshney <kshitiz.varshney@....com>,
 David Gstir <david@...ma-star.at>, Mimi Zohar <zohar@...ux.ibm.com>,
 James Bottomley <jejb@...ux.ibm.com>, Jarkko Sakkinen <jarkko@...nel.org>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>
Cc: "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 Gaurav Jain <gaurav.jain@....com>, Catalin Marinas
 <catalin.marinas@....com>, David Howells <dhowells@...hat.com>,
 "keyrings@...r.kernel.org" <keyrings@...r.kernel.org>,
 Fabio Estevam <festevam@...il.com>, Paul Moore <paul@...l-moore.com>,
 Jonathan Corbet <corbet@....net>, Richard Weinberger <richard@....at>,
 "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
 James Morris <jmorris@...ei.org>, dl-linux-imx <linux-imx@....com>,
 "Serge E. Hallyn" <serge@...lyn.com>, "Paul E. McKenney"
 <paulmck@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Pankaj Gupta <pankaj.gupta@....com>,
 sigma star Kernel Team <upstream+dcp@...ma-star.at>,
 "Steven Rostedt (Google)" <rostedt@...dmis.org>,
 David Oberhollenzer <david.oberhollenzer@...ma-star.at>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
 Randy Dunlap <rdunlap@...radead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Li Yang <leoyang.li@....com>,
 "linux-security-module@...r.kernel.org"
 <linux-security-module@...r.kernel.org>,
 "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
 Pengutronix Kernel Team <kernel@...gutronix.de>, Tejun Heo <tj@...nel.org>,
 "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
 Shawn Guo <shawnguo@...nel.org>, Varun Sethi <V.Sethi@....com>
Subject: Re: [EXT] [PATCH v8 3/6] KEYS: trusted: Introduce NXP DCP-backed
 trusted keys

Hello Kshitiz,

On 09.04.24 12:54, Kshitiz Varshney wrote:
> Hi David,
>> +       b->fmt_version = DCP_BLOB_VERSION;
>> +       get_random_bytes(b->nonce, AES_KEYSIZE_128);
>> +       get_random_bytes(b->blob_key, AES_KEYSIZE_128);
> 
> We can use HWRNG instead of using kernel RNG. Please refer drivers/char/hw_random/imx-rngc.c 

imx-rngc can be enabled and used to seed the kernel entropy pool. Adding
direct calls into imx-rngc here only introduces duplicated code at no extra
benefit.

Cheers,
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |