linux-kernel - Re: [PATCH 0/4] DONOTMERGE: ep93xx-clk from ep93xx device tree conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240409-unselect-denatured-6af8a07dbd9a@spud>
Date: Tue, 9 Apr 2024 18:32:03 +0100
From: Conor Dooley <conor@...nel.org>
To: Alexander Sverdlin <alexander.sverdlin@...il.com>
Cc: Nikita Shubin <nikita.shubin@...uefel.me>,
	Arnd Bergmann <arnd@...db.de>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH 0/4] DONOTMERGE: ep93xx-clk from ep93xx device tree
 conversion

On Tue, Apr 09, 2024 at 05:09:35PM +0200, Alexander Sverdlin wrote:
> Hi Nikita,
> 
> On Tue, 2024-04-09 at 14:48 +0300, Nikita Shubin wrote:
> > On Mon, 2024-04-08 at 18:03 +0100, Conor Dooley wrote:
> > > On Mon, Apr 08, 2024 at 11:09:52AM +0300, Nikita Shubin via B4 Relay
> > > wrote:
> > > > The goal is to recieve ACKs.
> > > 
> > > I dont see a maintainers entry in -rc1 for the drivers/soc/cirrus
> > > portion. Who is gonna give you an Ack for that portion? If you
> > > intended
> > > maintaining that driver, should you not add a MAINTAINERS entry for
> > > it?
> > 
> > drivers/soc/cirrus got it's ACK from ep93xx MAINTAINER - Alexander
> > Sverdlin.
> > 
> > Arnd, Alexander - should we add it now ?
> 
> seems that we have couple of things to fix:
> 
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #51: 
> new file mode 100644
> 
> WARNING: please write a help paragraph that fully describes the config symbol
> #60: FILE: drivers/soc/cirrus/Kconfig:5:
> +config EP93XX_SOC
> +	bool "Cirrus EP93xx chips SoC"
> +	select SOC_BUS
> +	select AUXILIARY_BUS
> +	default y if !EP93XX_SOC_COMMON
> +	help
> +	  Support SoC for Cirrus EP93xx chips.
> +
> 
> total: 0 errors, 2 warnings, 269 lines checked

FWIW, I wouldn't be too worried about meeting the minimum line check for
the Kconfig option that checkpatch requires - but the description here
is not clear what the driver does. 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)