linux-kernel - Re: [PATCH] spi: omap2-mcspi: Ensure that CS is correctly asserted when switching from MULTI mode to SINGLE mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7a41b650-b135-40cd-bf55-ee4aeea74fe6@sirena.org.uk>
Date: Tue, 9 Apr 2024 18:48:14 +0100
From: Mark Brown <broonie@...nel.org>
To: Louis Chauvet <louis.chauvet@...tlin.com>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	miquel.raynal@...tlin.com, thomas.petazzoni@...tlin.com,
	yen-mei.goh@...sight.com, jeremie.dautheribes@...tlin.com
Subject: Re: [PATCH] spi: omap2-mcspi: Ensure that CS is correctly asserted
 when switching from MULTI mode to SINGLE mode

On Tue, Apr 09, 2024 at 07:25:33PM +0200, Louis Chauvet wrote:
> The OMAP2 support features a "multi" mode, where the controller
> automatically sets the Chip Select (CS) when necessary. This mode allows
> for shorter delays between CS selection and word content, but the CS is
> always deasserted at the end.

This breaks the build due to updating for modern names, please rebase
and resend:

/build/stage/linux/drivers/spi/spi-omap2-mcspi.c: In function ‘omap2_mcspi_prepare_message’:
/build/stage/linux/drivers/spi/spi-omap2-mcspi.c:1274:17: error: ‘master’ undeclared (first use in this function)
 1274 |                 master->last_cs = -1;
      |                 ^~~~~~
/build/stage/linux/drivers/spi/spi-omap2-mcspi.c:1274:17: note: each undeclared identifier is reported only once for each function it appears in

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)