linux-kernel - Re: [PATCH v2] arm64: dts: ti: k3-j722s-evm: Enable eMMC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240409190635.twbv45ewbbprhqme@jimmy>
Date: Tue, 9 Apr 2024 14:06:35 -0500
From: Nishanth Menon <nm@...com>
To: Francesco Dolcini <francesco@...cini.it>
CC: Michael Walle <mwalle@...nel.org>, Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j722s-evm: Enable eMMC support

On 09:45-20240404, Francesco Dolcini wrote:
> Hello Michael,
> 
> On Wed, Apr 03, 2024 at 12:23:02PM +0200, Michael Walle wrote:
> > The J722S EVM has an on-board eMMC. Enable the SDHC interface for it.
> > There is no pinmuxing required because the interface has dedicated pins.
> > 
> > Signed-off-by: Michael Walle <mwalle@...nel.org>
> > ---
> > v2:
> >  - move status="okay" last
> > ---
> >  arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> > index cee3a8661d5e..6b148da2bcdc 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> > @@ -369,6 +369,13 @@ partition@...0000 {
> >  
> >  };
> >  
> > +&sdhci0 {
> > +	ti,driver-strength-ohm = <50>;
> 
> According to the latest DTS coding style guidelines this needs to be
> just before status.
> 
> https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node
> 
> Yes, we would need a checker, I know and I agree. At least now we moved
> out of the tribal knowledge way of working with every maintainer having
> slightly different expectation on this topic ... one step at a time :-)

Since this is the first cycle, I have done this fixup locally.
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D