linux-kernel - Re: [PATCH v2] watchdog: rti_wdt: Set min_hw_heartbeat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZhWchn3qr_7Ocggm@gaggiata.pivistrello.it>
Date: Tue, 9 Apr 2024 21:52:38 +0200
From: Francesco Dolcini <francesco@...cini.it>
To: Judith Mendez <jm@...com>
Cc: Guenter Roeck <linux@...ck-us.net>,
	Wim Van Sebroeck <wim@...ux-watchdog.org>,
	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
	Francesco Dolcini <francesco@...cini.it>
Subject: Re: [PATCH v2] watchdog: rti_wdt: Set min_hw_heartbeat_ms to
 accommodate 5% safety margin

On Tue, Apr 09, 2024 at 02:37:15PM -0500, Judith Mendez wrote:
> Hi all,
> 
> On 4/6/24 8:01 AM, Guenter Roeck wrote:
> > On Thu, Apr 04, 2024 at 10:33:19AM -0500, Judith Mendez wrote:
> > > On AM62x, the watchdog is pet before the valid window
> > > is open. Fix min_hw_heartbeat and accommodate a 5% safety
> > > margin with the exception of open window size < 10%,
> > > which shall use <5% due to the smaller open window size.
> 
> Please do not merge this patch, I will add an additional
> patch removing the hack in this driver.

Is the patch buggy, or you are just talking about an additional clean-up?
If it is an additional patch and this code is fine, why holding it back?

Thanks,
Francesco