linux-kernel - Re: [PATCH v1] scsi: ufs: exynos: Support module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZhWn-jKhqSihx8qA@google.com>
Date: Tue, 9 Apr 2024 13:41:30 -0700
From: William McVicker <willmcvicker@...gle.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Alim Akhtar <alim.akhtar@...sung.com>,
	"James E.J. Bottomley" <jejb@...ux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Peter Griffin <peter.griffin@...aro.org>, andre.draszik@...aro.org,
	tudor.ambarus@...aro.org, kernel-team@...roid.com,
	linux-scsi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] scsi: ufs: exynos: Support module autoloading

On 04/09/2024, Krzysztof Kozlowski wrote:
> On 09/04/2024 22:22, Will McVicker wrote:
> > Export the module alias information using the MODULE_DEVICE_TABLE()
> > macro in order to support auto-loading this module for devices that
> > support it.
> > 
> > $ modinfo -F alias out/linux/drivers/ufs/host/ufs-exynos.ko
> > of:N*T*Ctesla,fsd-ufsC*
> > of:N*T*Ctesla,fsd-ufs
> > of:N*T*Csamsung,exynosautov9-ufs-vhC*
> > of:N*T*Csamsung,exynosautov9-ufs-vh
> > of:N*T*Csamsung,exynosautov9-ufsC*
> > of:N*T*Csamsung,exynosautov9-ufs
> > of:N*T*Csamsung,exynos7-ufsC*
> > of:N*T*Csamsung,exynos7-ufs
> 
> That part is redundant, you just copied result of of_device_id. No need
> to resend just for this.

Well the point of including this snippet is to show that it's working.
Without this patch, `modinfo -F alias ufs-exynos.ko` doesn't return
anything. I'm fine with not including it either way though.

Thanks,
Will

> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Best regards,
> Krzysztof
>