linux-kernel - Re: [PATCH net-next v7 13/17] net: pse-pd: Use regulator framework within PSE framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240409141621.392bd34b@kernel.org>
Date: Tue, 9 Apr 2024 14:16:21 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet
 <corbet@....net>, Luis Chamberlain <mcgrof@...nel.org>, Russ Weight
 <russ.weight@...ux.dev>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
 <conor+dt@...nel.org>, Oleksij Rempel <o.rempel@...gutronix.de>, Mark Brown
 <broonie@...nel.org>, Frank Rowand <frowand.list@...il.com>, Andrew Lunn
 <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, devicetree@...r.kernel.org, Dent Project
 <dentproject@...uxfoundation.org>, kernel@...gutronix.de, Maxime Chevallier
 <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next v7 13/17] net: pse-pd: Use regulator framework
 within PSE framework

On Tue, 09 Apr 2024 17:04:03 +0200 Kory Maincent wrote:
> -static inline struct pse_control *of_pse_control_get(struct device_node *node)
> +static inline struct pse_control *of_pse_control_get(struct device *dev,
> +						     struct device_node *node)

One of the related patches breaks the build:

drivers/net/mdio/fwnode_mdio.c: In function ‘fwnode_find_pse_control’:
drivers/net/mdio/fwnode_mdio.c:32:35: error: passing argument 1 of ‘of_pse_control_get’ from incompatible pointer type [-Werror=incompatible-pointer-types]
   32 |         psec = of_pse_control_get(np);
      |                                   ^~
      |                                   |
      |                                   struct device_node *
In file included from drivers/net/mdio/fwnode_mdio.c:13:
/include/linux/pse-pd/pse.h:157:69: note: expected ‘struct device *’ but argument is of type ‘struct device_node *’
  157 | static inline struct pse_control *of_pse_control_get(struct device *dev,
      |                                                      ~~~~~~~~~~~~~~~^~~
drivers/net/mdio/fwnode_mdio.c:32:16: error: too few arguments to function ‘of_pse_control_get’
   32 |         psec = of_pse_control_get(np);
      |                ^~~~~~~~~~~~~~~~~~
In file included from drivers/net/mdio/fwnode_mdio.c:13:
/include/linux/pse-pd/pse.h:157:35: note: declared here
  157 | static inline struct pse_control *of_pse_control_get(struct device *dev,
      |                                   ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors