linux-kernel - Re: [PATCH v1 08/31] x86/resctrl: Move resctrl types to a separate header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ba51259-cb7a-463e-aabd-f88bd0c4007b@intel.com>
Date: Mon, 8 Apr 2024 20:18:00 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: James Morse <james.morse@....com>, <x86@...nel.org>,
	<linux-kernel@...r.kernel.org>
CC: Fenghua Yu <fenghua.yu@...el.com>, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, H Peter Anvin
	<hpa@...or.com>, Babu Moger <Babu.Moger@....com>,
	<shameerali.kolothum.thodi@...wei.com>, D Scott Phillips OS
	<scott@...amperecomputing.com>, <carl@...amperecomputing.com>,
	<lcherian@...vell.com>, <bobo.shaobowang@...wei.com>,
	<tan.shaopeng@...itsu.com>, <baolin.wang@...ux.alibaba.com>, Jamie Iles
	<quic_jiles@...cinc.com>, Xin Hao <xhao@...ux.alibaba.com>,
	<peternewman@...gle.com>, <dfustini@...libre.com>, <amitsinght@...vell.com>,
	David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>, Dave
 Martin <dave.martin@....com>
Subject: Re: [PATCH v1 08/31] x86/resctrl: Move resctrl types to a separate
 header

Hi James,

On 3/21/2024 9:50 AM, James Morse wrote:
> To avoid sticky problems in the mpam glue code, move the resctrl
> enums into a separate header.

Could you please elaborate so that "sticky problems in the mpam glue code" is
specific about what problems are avoided?

> 
> This lets the arch code declare prototypes that use these enums without
> creating a loop via asm<->linux resctrl.h The same logic applies to the
> monitor-configuration defines, move these too.
> 
> The maintainers entry for these headers was missed when resctrl.h
> was created. Add a wildcard entry to match both resctrl.h and
> resctrl_types.h.
> 
> Signed-off-by: James Morse <james.morse@....com>

..

> diff --git a/include/linux/resctrl_types.h b/include/linux/resctrl_types.h
> new file mode 100644
> index 000000000000..4788bd95dac6
> --- /dev/null
> +++ b/include/linux/resctrl_types.h
> @@ -0,0 +1,68 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2024 Arm Ltd.
> + * Based on arch/x86/kernel/cpu/resctrl/internal.h
> + */

Could this header please explain how this file is intended to be used?
What is it intended to contain?

Reinette