linux-kernel - Re: [RESEND][PATCH v9 4/7] sched: Add do_push

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 9 Apr 2024 15:36:20 -0700
From: John Stultz <jstultz@...gle.com>
To: Valentin Schneider <vschneid@...hat.com>
Cc: LKML <linux-kernel@...r.kernel.org>, "Connor O'Brien" <connoro@...gle.com>, 
	Joel Fernandes <joelaf@...gle.com>, Qais Yousef <qyousef@...gle.com>, Ingo Molnar <mingo@...hat.com>, 
	Peter Zijlstra <peterz@...radead.org>, Juri Lelli <juri.lelli@...hat.com>, 
	Vincent Guittot <vincent.guittot@...aro.org>, Dietmar Eggemann <dietmar.eggemann@....com>, 
	Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, 
	Zimuzo Ezeozue <zezeozue@...gle.com>, Youssef Esmat <youssefesmat@...gle.com>, 
	Mel Gorman <mgorman@...e.de>, Daniel Bristot de Oliveira <bristot@...hat.com>, Will Deacon <will@...nel.org>, 
	Waiman Long <longman@...hat.com>, Boqun Feng <boqun.feng@...il.com>, 
	"Paul E. McKenney" <paulmck@...nel.org>, Metin Kaya <Metin.Kaya@....com>, 
	Xuewen Yan <xuewen.yan94@...il.com>, K Prateek Nayak <kprateek.nayak@....com>, 
	Thomas Gleixner <tglx@...utronix.de>, kernel-team@...roid.com
Subject: Re: [RESEND][PATCH v9 4/7] sched: Add do_push_task helper

On Tue, Apr 9, 2024 at 9:30 AM Valentin Schneider <vschneid@...hat.com> wrote:
> Naming nit below notwithstanding:
>
> Reviewed-by: Valentin Schneider <vschneid@...hat.com>

Hey! Thanks so much for taking a look and providing this feedback! I
really appreciate it!

> > +static inline
> > +void do_push_task(struct rq *rq, struct rq *dst_rq, struct task_struct *task)
>
> The naming IMO unfortunately clashes with the hotplug push_task /
> balance_push() stuff.
>
> AFAICT this is move_queued_task() but in a double rq lock
> context. How about move_queued_task_locked()?

Sounds good to me! Changed in my pre-v10 tree.


> Interestingly, all the patched call sites end up with a resched_curr(), but
> move_queued_task() has wakeup_preempt() instead.

Yeah. I'll look a bit more to see if I can find a way to fold the
resched in as well, and try to make sure I understand the subtle
difference in move_queued_task() - I don't want the name similarity to
confuse if the behavior is different.

Again, thanks so much for the feedback and review!
-john