linux-kernel - Re: [PATCH net-next v5 1/3] net: make napi_frag_unref reuse skb_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dfe587e-b868-4066-8597-63cc3578e928@intel.com>
Date: Tue, 9 Apr 2024 16:56:08 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Mina Almasry <almasrymina@...gle.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
CC: Ayush Sawal <ayush.sawal@...lsio.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Jesper Dangaard Brouer
	<hawk@...nel.org>, Ilias Apalodimas <ilias.apalodimas@...aro.org>, "Steffen
 Klassert" <steffen.klassert@...unet.com>, Herbert Xu
	<herbert@...dor.apana.org.au>, David Ahern <dsahern@...nel.org>, "Boris
 Pismenny" <borisp@...dia.com>, John Fastabend <john.fastabend@...il.com>,
	Dragos Tatulea <dtatulea@...dia.com>
Subject: Re: [PATCH net-next v5 1/3] net: make napi_frag_unref reuse
 skb_page_unref



On 4/8/2024 8:29 AM, Mina Almasry wrote:
> The implementations of these 2 functions are almost identical. Remove
> the implementation of napi_frag_unref, and make it a call into
> skb_page_unref so we don't duplicate the implementation.
> 
> Signed-off-by: Mina Almasry <almasrymina@...gle.com>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> 

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>