linux-kernel - Re: Fwd: Steam Deck OLED 6.8.2 nau8821-max fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 9 Apr 2024 06:44:12 +0200
From: "Linux regression tracking (Thorsten Leemhuis)"
 <regressions@...mhuis.info>
To: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
 Linux regressions mailing list <regressions@...ts.linux.dev>,
 Bagas Sanjaya <bagasdotme@...il.com>,
 Venkata Prasad Potturu <venkataprasad.potturu@....com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
 Arun Gopal Kondaveeti <arungopal.kondaveeti@....com>,
 Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
 Daniel <dmanlfc@...il.com>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux Sound System <linux-sound@...r.kernel.org>
Subject: Re: Fwd: Steam Deck OLED 6.8.2 nau8821-max fails

On 09.04.24 01:44, Cristian Ciocaltea wrote:
> On 4/7/24 10:47 AM, Linux regression tracking (Thorsten Leemhuis) wrote:
>> On 06.04.24 15:08, Bagas Sanjaya wrote:
>>>
>>> On Bugzilla, Daniel <dmanlfc@...il.com> reported topology regression
>>> on Steam Deck OLED [1]. He wrote:
>
>>>> I'm adding this here, I hope it's the correct place.
>>>>
>>>> Currently the Steam Deck OLED fails with Kernel 6.8.2 when trying to initialise the topology for the device.
>>>> I'm using the `sof-vangogh-nau8821-max.tplg` file from the Steam Deck OLED and associated firmware.
>>>
>>> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=218677
>>
>> A quick search made me find these posts/threads that foreshadow the problem:
>>
>> https://lore.kernel.org/lkml/20231219030728.2431640-1-cristian.ciocaltea@collabora.com/
>> https://lore.kernel.org/all/a3357e1f-f354-4d4b-9751-6b2182dceea6@amd.com/
>>
>> From a quick look at the second discussion it seems a bit like we are
>> screwed, as iiutc topology files are out in the wild for one or the
>> other approach. So we might have to bite a bullet there and accept the
>> regression -- but I might easily be totally mistaken here. Would be good
>> in one of the experts (Venkata Prasad Potturu maybe?) could quickly
>> explain what's up here.
> 
> The problem here is that Steam Deck OLED provides a topology file which
> uses an incorrect DAI link ID for BT codec. 
> 
> Patch [1] moves BT_BE_ID to position 2 in the enum, as expected by the
> topology, but this is not a change that can be accepted upstream as it
> would break other devices which rely on BT_BE_ID set to 3.  
> 
> The proper solution would be to update the topology file on Steam Deck,
> but this is probably not straightforward to be accomplished as it would
> break the compatibility with the currently released (downstream)
> kernels.
> 
> Hopefully, this sheds some more light on the matter.
>
> [1]: https://lore.kernel.org/all/20231209205351.880797-11-cristian.ciocaltea@collabora.com/

Many thx, yes, this sheds some light on the matter. But there is one
remaining question: can we make both camps happy somehow? E.g. something
along the lines of "first detect if the topology file has BT_BE_ID in
position 2 or 3 and then act accordingly?

Ciao, Thorsten