linux-kernel - Re: [PATCH] mm: vmscan: do not skip CMA while LRU is full of CMA folios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e99fd119-c1a1-4d4d-9483-f7c4a4377441@oppo.com>
Date: Tue, 9 Apr 2024 04:54:15 +0000
From: 刘海龙(LaoLiu) <liuhailong@...o.com>
To: Oscar Salvador <osalvador@...e.de>
CC: "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"nathan@...nel.org" <nathan@...nel.org>, "ndesaulniers@...gle.com"
	<ndesaulniers@...gle.com>, "trix@...hat.com" <trix@...hat.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "llvm@...ts.linux.dev"
	<llvm@...ts.linux.dev>, "surenb@...gle.com" <surenb@...gle.com>,
	"zhaoyang.huang@...soc.com" <zhaoyang.huang@...soc.com>,
	"quic_charante@...cinc.com" <quic_charante@...cinc.com>, "yuzhao@...gle.com"
	<yuzhao@...gle.com>
Subject: Re: [PATCH] mm: vmscan: do not skip CMA while LRU is full of CMA
 folios

On 2024/4/8 16:38, Oscar Salvador wrote:
> On Mon, Apr 08, 2024 at 04:05:39PM +0800, liuhailong@...o.com wrote:
>> From: liuhailong <liuhailong@...o.com>
>> @@ -6202,6 +6213,16 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
>>  		 */
>>  		if (sc->priority < DEF_PRIORITY - 2)
>>  			sc->may_writepage = 1;
>> +
>> +		/*
>> +		 * If we're getting trouble reclaiming non-cma pages and
>> +		 * currently a substantial number of CMA pages on LRU,
> "sit on LRU" ?
Got it, Thanks
> 
>> +		 * start reclaiming cma pages to alleviate other threads
>> +		 * and decrease lru size.
>> +		 */
>> +		if (sc->priority < DEF_PRIORITY - 2 &&
>> +		    sc->nr_scanned < (sc->nr_skipped_cma >> 3))
> 
> Why "sc->nr_skipped_cma >> 3"? It feels a bit hardcoded.
> Maybe the comment or the changelog should contain a reference about why
> this "/8" was a good choice.

When the number of skipped CMA ages exceeds eight times the number of
scanned pages, it indicates that CMA pages constitute the majority
of the LRU pages. Setting the value too low may result in premature
reclamation of CMA pages, which are unnecessary for non-movable
allocations. Conversely, setting it too high may delay problem detection
until much later, wasting CPU time in idle loops.

Brs,
Hailong.