linux-kernel - Re: [PATCH v4] mtd: rawnand: qcom: Fix broken OP_RESET_DEVICE command in qcom_misc_cmd_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240409064133.91927-1-miquel.raynal@bootlin.com>
Date: Tue,  9 Apr 2024 08:41:33 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Christian Marangi <ansuelsmth@...il.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	Richard Weinberger <richard@....at>,
	Vignesh Raghavendra <vigneshr@...com>,
	Md Sadre Alam <quic_mdalam@...cinc.com>,
	Sricharan Ramabadhran <quic_srichara@...cinc.com>,
	linux-mtd@...ts.infradead.org,
	linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: stable@...r.kernel.org
Subject: Re: [PATCH v4] mtd: rawnand: qcom: Fix broken OP_RESET_DEVICE command in qcom_misc_cmd_type_exec()

On Thu, 2024-04-04 at 08:31:55 UTC, Christian Marangi wrote:
> While migrating to exec_ops in commit a82990c8a409 ("mtd: rawnand: qcom:
> Add read/read_start ops in exec_op path"), OP_RESET_DEVICE command handling
> got broken unintentionally. Right now for the OP_RESET_DEVICE command,
> qcom_misc_cmd_type_exec() will simply return 0 without handling it. Even,
> if that gets fixed, an unnecessary FLASH_STATUS read descriptor command is
> being added in the middle and that seems to be causing the command to fail
> on IPQ806x devices.
> 
> So let's fix the above two issues to make OP_RESET_DEVICE command working
> again.
> 
> Fixes: a82990c8a409 ("mtd: rawnand: qcom: Add read/read_start ops in exec_op path")
> Cc: stable@...r.kernel.org
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel