linux-kernel - Re: [RFC 3/3] x86: KVM: stats: Add a stat counter for GALog events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZhTj8kdChoqSLpi8@chao-email>
Date: Tue, 9 Apr 2024 14:45:06 +0800
From: Chao Gao <chao.gao@...el.com>
To: Alejandro Jimenez <alejandro.j.jimenez@...cle.com>
CC: <kvm@...r.kernel.org>, <seanjc@...gle.com>, <pbonzini@...hat.com>,
	<linux-kernel@...r.kernel.org>, <joao.m.martins@...cle.com>,
	<boris.ostrovsky@...cle.com>, <mark.kanda@...cle.com>,
	<suravee.suthikulpanit@....com>, <mlevitsk@...hat.com>
Subject: Re: [RFC 3/3] x86: KVM: stats: Add a stat counter for GALog events

>diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c
>index 4b74ea91f4e6..853cafe4a9af 100644
>--- a/arch/x86/kvm/svm/avic.c
>+++ b/arch/x86/kvm/svm/avic.c
>@@ -165,8 +165,10 @@ int avic_ga_log_notifier(u32 ga_tag)
> 	 * bit in the vAPIC backing page. So, we just need to schedule
> 	 * in the vcpu.
> 	 */
>-	if (vcpu)
>+	if (vcpu) {
> 		kvm_vcpu_wake_up(vcpu);
>+		++vcpu->stat.ga_log_event;
>+	}
> 

I am not sure why this is added for SVM only. it looks to me GALog events are
similar to Intel IOMMU's wakeup events. Can we have a general name? maybe
iommu_wakeup_event

and increase the counter after the kvm_vcpu_wake_up() call in pi_wakeup_handler().