lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bc841a30-57d7-44c6-92e2-9a84e856e733@linaro.org>
Date: Tue, 9 Apr 2024 09:44:00 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Cristian Marussi <cristian.marussi@....com>,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org
Cc: sudeep.holla@....com, jassisinghbrar@...il.com, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: mailbox: arm,mhuv3: Add bindings

On 04/04/2024 08:23, Cristian Marussi wrote:
> Add bindings for the ARM MHUv3 Mailbox controller.
> 
> Signed-off-by: Cristian Marussi <cristian.marussi@....com>

..

> +        mailbox@...a0000 {
> +            compatible = "arm,mhuv3";
> +            #mbox-cells = <3>;
> +            reg = <0 0x2aaa0000 0 0x10000>;
> +            clocks = <&clock 0>;
> +            interrupt-names = "combined", "pbx-dbch-xfer-ack-1",
> +                               "ffch-high-tide-0";
> +            interrupts = <0 36 4>, <0 37 4>;
> +        };
> +
> +        mailbox@...00000 {
> +            compatible = "arm,mhuv3";
> +            #mbox-cells = <3>;
> +            reg = <0 0x2aab0000 0 0x10000>;
> +            clocks = <&clock 0>;
> +            interrupt-names = "combined", "mbx-dbch-xfer-1", "ffch-low-tide-0";
> +            interrupts = <0 35 4>, <0 38 4>, <0 39 4>;

Use defines for GIC and level flags.

With this fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ