linux-kernel - Re: [PATCH] [v3] parport: mfc3: avoid empty-body warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdUPX+Tx9y3AGFXgVM8G0YkSLgmmNUPCQCX8L9Q_kg5muA@mail.gmail.com>
Date: Tue, 9 Apr 2024 09:52:01 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Arnd Bergmann <arnd@...db.de>, 
	Sudip Mukherjee <sudipm.mukherjee@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v3] parport: mfc3: avoid empty-body warning

Hi Arnd,

Thanks for your patch!

On Fri, Apr 5, 2024 at 4:43 PM Arnd Bergmann <arnd@...nel.org> wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> on m68k builds, the mfc3 driver causes a warning about an empty if() block:
>
> drivers/parport/parport_mfc3.c: In function 'control_pc_to_mfc3':
> drivers/parport/parport_mfc3.c:106:37: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
>
> Remove it in favor of a simpler comment.
>
> Acked-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> Link: https://lore.kernel.org/lkml/20230727122448.2479942-1-arnd@kernel.org/

Why the Link-tag, pointing to v2?

> Signed-off-by: Arnd Bergmann <arnd@...db.de>

For the actual patch:
Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds