linux-kernel - Re: [PATCH v2 1/2] dt-bindings: mtd: amlogic,meson-nand: support fields for boot ROM code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <171262614183.5405.15027515085421244232.robh@kernel.org>
Date: Mon, 08 Apr 2024 20:29:05 -0500
From: Rob Herring <robh@...nel.org>
To: Arseniy Krasnov <avkrasnov@...utedevices.com>
Cc: kernel@...rdevices.ru, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
 Rob Herring <robh+dt@...nel.org>, 
 Neil Armstrong <neil.armstrong@...aro.org>, devicetree@...r.kernel.org, 
 linux-kernel@...r.kernel.org, oxffffaa@...il.com, 
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>, 
 Conor Dooley <conor+dt@...nel.org>, 
 Miquel Raynal <miquel.raynal@...tlin.com>, 
 linux-arm-kernel@...ts.infradead.org, Kevin Hilman <khilman@...libre.com>, 
 Richard Weinberger <richard@....at>, linux-mtd@...ts.infradead.org, 
 Vignesh Raghavendra <vigneshr@...com>, Jerome Brunet <jbrunet@...libre.com>, 
 linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: amlogic,meson-nand: support
 fields for boot ROM code


On Mon, 08 Apr 2024 11:59:30 +0300, Arseniy Krasnov wrote:
> Boot ROM code on Meson requires that some pages on NAND must be written
> in special mode: "short" ECC mode where each block is 384 bytes and
> scrambling mode is on. Such pages located with the specified interval
> within specified offset. Both interval and offset are located in the
> device tree and used by driver if 'nand-is-boot-medium' is set for
> NAND chip.
> 
> Signed-off-by: Arseniy Krasnov <avkrasnov@...utedevices.com>
> ---
>  .../bindings/mtd/amlogic,meson-nand.yaml           | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml:84:61: [warning] too few spaces after comma (commas)
/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml:85:61: [warning] too few spaces after comma (commas)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240408085931.456337-2-avkrasnov@salutedevices.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.