linux-kernel - Re: [PATCH] riscv: dts: sophgo: add initial Milk-V Duo S board device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5074974-d80c-466f-b226-f7a776a18a7c@kernel.org>
Date: Tue, 9 Apr 2024 11:47:08 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: michael.opdenacker@...tlin.com, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chen Wang <unicorn_wang@...look.com>,
 Inochi Amaoto <inochiama@...look.com>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>
Cc: devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: dts: sophgo: add initial Milk-V Duo S board device
 tree

On 09/04/2024 08:45, michael.opdenacker@...tlin.com wrote:
> From: Michael Opdenacker <michael.opdenacker@...tlin.com>
> 
> This adds initial support for the Milk-V Duo S board
> (https://milkv.io/duo-s), enabling the serial port and
> read-only SD card support, allowing to boot Linux to the
> command line.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@...tlin.com>
> 
> ---
> 
> Tested with linux-next as of Apr 9, 2024,
> using the risc-v "defconfig" configuration.

Please include in your tests what submitting patches and your maintainer
profile asks you. checkpatch and testing of DTS.

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.


Best regards,
Krzysztof