linux-kernel - Re: [PATCH] fs/dcache: Re-use value stored to dentry->d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240409-gattung-vorsehen-0187be2ab894@brauner>
Date: Tue,  9 Apr 2024 12:29:22 +0200
From: Christian Brauner <brauner@...nel.org>
To: linke li <lilinke99@...com>
Cc: Christian Brauner <brauner@...nel.org>,
	xujianhao01@...il.com,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Jan Kara <jack@...e.cz>,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/dcache: Re-use value stored to dentry->d_flags instead of re-reading

On Wed, 03 Apr 2024 10:10:08 +0800, linke li wrote:
> Currently, the __d_clear_type_and_inode() writes the value flags to
> dentry->d_flags, then immediately re-reads it in order to use it in a if
> statement. This re-read is useless because no other update to
> dentry->d_flags can occur at this point.
> 
> This commit therefore re-use flags in the if statement instead of
> re-reading dentry->d_flags.
> 
> [...]

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] fs/dcache: Re-use value stored to dentry->d_flags instead of re-reading
      https://git.kernel.org/vfs/vfs/c/8bfb40be31dd