linux-kernel - Re: [PATCH] erofs: derive fsid from on-disk UUID for .statfs() if possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 9 Apr 2024 19:23:09 +0800
From: Hongzhen Luo <hongzhen@...ux.alibaba.com>
To: Jingbo Xu <jefflexu@...ux.alibaba.com>, xiang@...nel.org,
 chao@...nel.org, linux-erofs@...ts.ozlabs.org
Cc: huyue2@...lpad.com, dhavale@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] erofs: derive fsid from on-disk UUID for .statfs() if
 possible


在 2024/4/9 17:36, Jingbo Xu 写道:
>
> On 4/9/24 4:11 PM, Hongzhen Luo wrote:
>> Use the superblock's UUID to generate the fsid when it's non-null.
>>
>> Signed-off-by: Hongzhen Luo <hongzhen@...ux.alibaba.com>
>> ---
>>   fs/erofs/super.c | 12 +++++-------
>>   1 file changed, 5 insertions(+), 7 deletions(-)
>>
>> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
>> index c0eb139adb07..83bd8ee3b5ba 100644
>> --- a/fs/erofs/super.c
>> +++ b/fs/erofs/super.c
>> @@ -923,22 +923,20 @@ static int erofs_statfs(struct dentry *dentry, struct kstatfs *buf)
>>   {
>>   	struct super_block *sb = dentry->d_sb;
>>   	struct erofs_sb_info *sbi = EROFS_SB(sb);
>> -	u64 id = 0;
>> -
>> -	if (!erofs_is_fscache_mode(sb))
>> -		id = huge_encode_dev(sb->s_bdev->bd_dev);
>>   
>>   	buf->f_type = sb->s_magic;
>>   	buf->f_bsize = sb->s_blocksize;
>>   	buf->f_blocks = sbi->total_blocks;
>>   	buf->f_bfree = buf->f_bavail = 0;
>> -
>>   	buf->f_files = ULLONG_MAX;
>>   	buf->f_ffree = ULLONG_MAX - sbi->inos;
>> -
>>   	buf->f_namelen = EROFS_NAME_LEN;
>>   
>> -	buf->f_fsid    = u64_to_fsid(id);
>> +	if (uuid_is_null(&sb->s_uuid))
>> +		buf->f_fsid = u64_to_fsid(erofs_is_fscache_mode(sb) ? 0 :
>> +				huge_encode_dev(sb->s_bdev->bd_dev));
>> +	else
>> +		buf->f_fsid = uuid_to_fsid((__u8 *)&sb->s_uuid);
> How about
>
> 	buf->f_fsid = uuid_to_fsid(sb->s_uuid.b);
>
> which looks cleaner.
>
> Otherwise LGTM.
>
> Reviewed-by: Jingbo Xu <jefflexu@...ux.alibaba.com>
>
>
Thanks. I will send v2 later.

---

Hongzhen