linux-kernel - Re: [PATCH] clk: Check ops are available in clk_gate_restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8415e2f4065ede19c6999708d64e8619.sboyd@kernel.org>
Date: Tue, 09 Apr 2024 04:31:49 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Cristian Marussi <cristian.marussi@....com>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: sudeep.holla@....com, peng.fan@....nxp.com, Cristian Marussi <cristian.marussi@....com>, Michael Turquette <mturquette@...libre.com>, linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: Check ops are available in clk_gate_restore_context

Quoting Cristian Marussi (2024-01-20 02:07:11)
> Add a check in clk_gate_restore_context() to assure that the clock enable
> and disable ops are available before calling them.
> 
> CC: Michael Turquette <mturquette@...libre.com>
> CC: Stephen Boyd <sboyd@...nel.org>
> CC: linux-clk@...r.kernel.org
> Fixes: 9be766274db4 ("clk: Clean up suspend/resume coding style")
> Signed-off-by: Cristian Marussi <cristian.marussi@....com>
> ---
> Spotted this by code inspection.
> I may be missing something, though, given my limited familiarity with CLK.

It assumes this is for a gate clk, which has enable/disable clk ops.
Also, only TI uses this code and I suggest you don't use it.