linux-kernel - Re: [net-next PATCH] octeontx2-pf: Add support for offload tc with skbedit mark action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9fde608268413dda70bb6ef328b8d823d568f74.camel@redhat.com>
Date: Tue, 09 Apr 2024 14:06:59 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Geetha sowjanya <gakula@...vell.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com, 
	sgoutham@...vell.com, sbhatta@...vell.com, hkelam@...vell.com
Subject: Re: [net-next PATCH] octeontx2-pf: Add support for offload tc with
 skbedit mark action

On Mon, 2024-04-08 at 12:56 +0530, Geetha sowjanya wrote:
> Support offloading of skbedit mark action.
> 
> For example, to mark with 0x0008, with dest ip 60.60.60.2 on eth2
> interface:
> 
>  # tc qdisc add dev eth2 ingress
>  # tc filter add dev eth2 ingress protocol ip flower \
>       dst_ip 60.60.60.2 action skbedit mark 0x0008 skip_sw
> 
> Signed-off-by: Geetha sowjanya <gakula@...vell.com>
> ---
>  .../net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c  |  2 ++
>  .../ethernet/marvell/octeontx2/nic/otx2_common.h    |  2 ++
>  .../net/ethernet/marvell/octeontx2/nic/otx2_tc.c    | 13 +++++++++++++
>  .../net/ethernet/marvell/octeontx2/nic/otx2_txrx.c  |  3 +++
>  .../net/ethernet/marvell/octeontx2/nic/otx2_txrx.h  |  3 +++
>  5 files changed, 23 insertions(+)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
> index c75669c8fde7..6188921e9a20 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
> @@ -1183,6 +1183,8 @@ static int npc_update_rx_entry(struct rvu *rvu, struct rvu_pfvf *pfvf,
>  			action.pf_func = target;
>  			action.op = NIX_RX_ACTIONOP_UCAST;
>  		}
> +		if (req->match_id)
> +			action.match_id = req->match_id;
>  	}
>  
>  	entry->action = *(u64 *)&action;
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> index 06910307085e..815ae13c371c 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> @@ -363,6 +363,7 @@ struct otx2_flow_config {
>  	struct list_head	flow_list;
>  	u32			dmacflt_max_flows;
>  	u16                     max_flows;
> +	u16			mark_flows;

Since the above fields is used as (reference) counter for the
OTX2_FLAG_TC_MARK_ENABLED bit, what about using a refcount_t, so you
gain sanity checks for free?

Thanks!

Paolo