linux-kernel - Re: [PATCH] riscv: dts: sophgo: add initial Milk-V Duo S board device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <IA1PR20MB49534E00CAE29D24F7D7E718BB072@IA1PR20MB4953.namprd20.prod.outlook.com>
Date: Tue, 9 Apr 2024 20:27:59 +0800
From: Inochi Amaoto <inochiama@...look.com>
To: Conor Dooley <conor@...nel.org>, Inochi Amaoto <inochiama@...look.com>
Cc: michael.opdenacker@...tlin.com, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Chen Wang <unicorn_wang@...look.com>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, devicetree@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: dts: sophgo: add initial Milk-V Duo S board
 device tree

On Tue, Apr 09, 2024 at 01:13:32PM +0100, Conor Dooley wrote:
> On Tue, Apr 09, 2024 at 03:17:35PM +0800, Inochi Amaoto wrote:
> > On Tue, Apr 09, 2024 at 08:45:04AM +0200, michael.opdenacker@...tlin.com wrote:
> > > From: Michael Opdenacker <michael.opdenacker@...tlin.com>
> > > 
> > > This adds initial support for the Milk-V Duo S board
> > > (https://milkv.io/duo-s), enabling the serial port and
> > > read-only SD card support, allowing to boot Linux to the
> > > command line.
> > > 
> > 
> > Hi Michael,
> > 
> > I think your patch losts the board binding and have wrong compatiable. 
> > Also, the SD can have rw support with proper property. See link [1] 
> > (need 'disable-wp').
> 
> [1] doesn't go anywhere useful.
> 

This is my fault, I copied the wrong url. The right patch is
https://lore.kernel.org/r/20240217144826.3944-1-jszhang@kernel.org.

> > I suggest you resubmitting this patch after applying clk patchs. 
> > This could reduce some unnecessary change. For now, you can just 
> > use the dts for huashan-pi (with changed memory size).
> 
> Why would using patched huashan-pi dts be more suitable than carrying
> a local patch for duo-s devicetree? What am I missing?
> 
> Cheers,
> Conor.
> 
> > 
> > [1]: https://lore.kernel.org/linux-riscv/IA1PR20MB4953B158F6F575840F3D4267BB7D2@IA1PR20MB4953.namprd20.prod.outlook.com/

I think you miss nothing. Using huashan-pi dts as a temporary 
solution is just because they are both CV181X series. Since
only a few peripherals are supported, it is also OK to use duo 
dts with local change. They're not significantly different.
This is also the reason I did not prepare any patch for the 
new board. (such as lichee RV NANO, duo 256).