linux-kernel - Re: [PATCH 1/2] dt-bindings: power: supply: ltc3350-charger: Add bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ff7ab51-b671-4a77-9abd-f4683fcc744d@topic.nl>
Date: Tue, 9 Apr 2024 14:34:29 +0200
From: Mike Looijmans <mike.looijmans@...ic.nl>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 linux-pm@...r.kernel.org
CC: Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Rob Herring <robh@...nel.org>, Sebastian Reichel <sre@...nel.org>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: ltc3350-charger: Add
 bindings

Thanks for your feedback. Will fix them all, except see below.

I'll send a v2

On 09-04-2024 10:27, Krzysztof Kozlowski wrote:
..
>> +
>> +  lltc,rsnsc-micro-ohms:
>> +    description: Capacitor charger sense resistor in microohm.
>> +    minimum: 1000
>> +
>> +  lltc,rsnsi-micro-ohms:
>> +    description: Input current sense resistor in microohm.
>> +    minimum: 1000
> Looks like it is shunt-resistor-micro-ohms. Unless it is something
> different?

It's a shunt, but different and there's two of them (akin to the 
ltc4162-l which has the same property with the same meaning). One to 
measure input, one to measure charge current.

When the datasheet talks about "shunt" it means the resistor that can be 
used to balance or discharge the caps. So I'd rather avoid the word 
completely so users aren't tempted to put the wrong resistor value there.

The datasheet uses "rsnsi" and "rsnsc" whenever referring to these 
resistors.

..

-- 
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@...ic.nl
W: www.topic.nl