linux-kernel - Re: [tip: timers/urgent] timekeeping: Use READ/WRITE_ONCE() for tick_do_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 10 Apr 2024 16:54:34 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Cc: linux-tip-commits@...r.kernel.org, Mirsad Todorovac
 <mirsad.todorovac@....unizg.hr>, Sean Anderson <sean.anderson@...o.com>,
 x86@...nel.org
Subject: Re: [tip: timers/urgent] timekeeping: Use READ/WRITE_ONCE() for
 tick_do_timer_cpu

On Wed, Apr 10 2024 at 10:15, Ingo Molnar wrote:
>> @@ -232,7 +233,7 @@ static void tick_setup_device(struct tick_device *td,
>>  						!tick_nohz_full_cpu(cpu)) {
>>  			tick_take_do_timer_from_boot();
>>  			tick_do_timer_boot_cpu = -1;
>> -			WARN_ON(tick_do_timer_cpu != cpu);
>> +			WARN_ON(READ_ON_ONCE(tick_do_timer_cpu) != cpu);
>
> So there's no such thing as READ_ON_ONCE() - I've amended the commit with 
> the fix below.

Can you hand me a brown paper bag please?