linux-kernel - Re: [PATCH RESEND] drm/armada: drop unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c612f63-fd7d-4f5a-ace6-05b2bc29f3eb@linaro.org>
Date: Wed, 10 Apr 2024 17:20:15 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Russell King <linux@...linux.org.uk>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: Re: [PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS

On 10/04/2024 10:22, Krzysztof Kozlowski wrote:
> The MODULE_DEVICE_TABLE already creates proper alias for platform
> driver.  Having another MODULE_ALIAS causes the alias to be duplicated.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Resent third time
> https://lore.kernel.org/all/20220407202443.23000-1-krzysztof.kozlowski@linaro.org/
> 
> Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> Cc: Neil Armstrong <neil.armstrong@...aro.org>
> ---
>   drivers/gpu/drm/armada/armada_drv.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
> index e51ecc4f7ef4..f48e2cf8de43 100644
> --- a/drivers/gpu/drm/armada/armada_drv.c
> +++ b/drivers/gpu/drm/armada/armada_drv.c
> @@ -283,4 +283,3 @@ module_exit(armada_drm_exit);
>   MODULE_AUTHOR("Russell King <rmk+kernel@...linux.org.uk>");
>   MODULE_DESCRIPTION("Armada DRM Driver");
>   MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:armada-drm");

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>

I think we'll need maxime or thomas ack to apply this via drm-misc-next

Neil