linux-kernel - Re: [PATCH net-next v6 5/9] net: dsa: microchip: add support for different DCB app configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 10 Apr 2024 18:11:25 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Vladimir Oltean <olteanv@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>,
	Eric Dumazet <edumazet@...gle.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Woojung Huh <woojung.huh@...rochip.com>,
	Arun Ramadoss <arun.ramadoss@...rochip.com>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	UNGLinuxDriver@...rochip.com, David Ahern <dsahern@...nel.org>,
	Simon Horman <horms@...nel.org>,
	Willem de Bruijn <willemb@...gle.com>,
	Søren Andersen <san@...v.dk>
Subject: Re: [PATCH net-next v6 5/9] net: dsa: microchip: add support for
 different DCB app configurations

On Wed, Apr 10, 2024 at 06:32:36PM +0300, Vladimir Oltean wrote:
> On Wed, Apr 10, 2024 at 10:05:52AM +0200, Oleksij Rempel wrote:
> > diff --git a/drivers/net/dsa/microchip/ksz_dcb.c b/drivers/net/dsa/microchip/ksz_dcb.c
> > new file mode 100644
> > index 0000000000000..d2122f844c80b
> > --- /dev/null
> > +++ b/drivers/net/dsa/microchip/ksz_dcb.c
> > +/**
> > + * ksz_supported_apptrust[] - Supported apptrust selectors and Priority Order
> > + *			      of Internal Priority Value (IPV) sources.
> > + *
> > + * This array defines the apptrust selectors supported by the hardware, where
> > + * the index within the array indicates the priority of the selector - lower
> > + * indices correspond to higher priority. This fixed priority scheme is due to
> > + * the hardware's design, which does not support configurable priority among
> > + * different priority sources.
> > + *
> > + * The priority sources, including Tail Tag, ACL, VLAN PCP and DSCP are ordered
> > + * by the hardware's fixed logic, as detailed below. The order reflects a
> > + * non-configurable precedence where certain types of priority information
> > + * override others:
> > + *
> > + * 1. Tail Tag - Highest priority, overrides ACL, VLAN PCP, and DSCP priorities.
> > + * 2. ACL - Overrides VLAN PCP and DSCP priorities.
> > + * 3. VLAN PCP - Overrides DSCP priority.
> > + * 4. DSCP - Lowest priority, does not override any other priority source.
> > + *
> > + * In this context, the array's lower index (higher priority) for
> > + * 'DCB_APP_SEL_PCP' suggests its relative priority over
> > + * 'IEEE_8021QAZ_APP_SEL_DSCP' within the system's fixed priority scheme.
> > + *
> > + * DCB_APP_SEL_PCP - Priority Code Point selector
> > + * IEEE_8021QAZ_APP_SEL_DSCP - Differentiated Services Code Point selector
> > + */
> > +static const u8 ksz_supported_apptrust[] = {
> > +	DCB_APP_SEL_PCP,
> > +	IEEE_8021QAZ_APP_SEL_DSCP,
> > +};
> 
> I've no idea how kernel-doc is supposed to document arrays. But this
> generates a scripts/kernel-doc warning:
> 
>   CHECK   ../drivers/net/dsa/microchip/ksz_dcb.c
> ./drivers/net/dsa/microchip/ksz_dcb.c:81: warning: cannot understand function prototype: 'const u8 ksz_supported_apptrust[] = '
> 
> Worst case, it doesn't need to be a kernel-doc?

I can remove the part which makes this comment a kenrel doc.

Are there other issues for this patch? Can it get your Reviewed-by if
fixed?

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |