linux-kernel - Re: [PATCH v2 0/4] perf test: "object code reading" test fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fVgf3cOgbV1KGGLd5gykxT+BzuX1=XUsp+2BNUahGn6QQ@mail.gmail.com>
Date: Wed, 10 Apr 2024 09:17:04 -0700
From: Ian Rogers <irogers@...gle.com>
To: James Clark <james.clark@....com>
Cc: linux-perf-users@...r.kernel.org, namhyung@...nel.org, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, "Liang, Kan" <kan.liang@...ux.intel.com>, 
	Athira Rajeev <atrajeev@...ux.vnet.ibm.com>, Spoorthy S <spoorts2@...ibm.com>, 
	Leo Yan <leo.yan@...ux.dev>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] perf test: "object code reading" test fixes

On Wed, Apr 10, 2024 at 3:35 AM James Clark <james.clark@....com> wrote:
>
> A few fixes around the object code reading test. The first patch
> appears to be unrelated, but in this case the data symbol test is
> broken on Arm N1 by the second commit.
>
> Changes since V1:
>   * Put data symbol test fix first so that bisecting still works on N1
>   * Instead of skipping "test data symbol" on N1, add some noise into
>     the loop.
>   * Add a commit to replace the only usage of lscpu in the tests with
>     uname
>
> James Clark (4):
>   perf tests: Make "test data symbol" more robust on Neoverse N1
>   perf tests: Apply attributes to all events in object code reading test
>   perf map: Remove kernel map before updating start and end addresses
>   perf tests: Remove dependency on lscpu

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

>  tools/perf/tests/code-reading.c                 | 10 +++++-----
>  tools/perf/tests/shell/test_arm_callgraph_fp.sh |  4 +++-
>  tools/perf/tests/workloads/datasym.c            | 16 ++++++++++++++++
>  tools/perf/util/machine.c                       |  2 +-
>  4 files changed, 25 insertions(+), 7 deletions(-)
>
> --
> 2.34.1
>