linux-kernel - Re: [PATCH v1 4/5] s390/uv: update PG_arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 10 Apr 2024 19:19:44 +0200
From: Claudio Imbrenda <imbrenda@...ux.ibm.com>
To: David Hildenbrand <david@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-s390@...r.kernel.org, kvm@...r.kernel.org,
        Matthew Wilcox
 <willy@...radead.org>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik
 <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian
 Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle
 <svens@...ux.ibm.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        Gerald
 Schaefer <gerald.schaefer@...ux.ibm.com>,
        Thomas Huth <thuth@...hat.com>
Subject: Re: [PATCH v1 4/5] s390/uv: update PG_arch_1 comment

On Thu,  4 Apr 2024 18:36:41 +0200
David Hildenbrand <david@...hat.com> wrote:

> We removed the usage of PG_arch_1 for page tables in commit
> a51324c430db ("s390/cmma: rework no-dat handling").
> 
> Let's update the comment in UV to reflect that.
> 
> Signed-off-by: David Hildenbrand <david@...hat.com>

Reviewed-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>

> ---
>  arch/s390/kernel/uv.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
> index 9c0113b26735..76fc61333fae 100644
> --- a/arch/s390/kernel/uv.c
> +++ b/arch/s390/kernel/uv.c
> @@ -471,13 +471,12 @@ int arch_make_page_accessible(struct page *page)
>  		return 0;
>  
>  	/*
> -	 * PG_arch_1 is used in 3 places:
> -	 * 1. for kernel page tables during early boot
> -	 * 2. for storage keys of huge pages and KVM
> -	 * 3. As an indication that this small folio might be secure. This can
> +	 * PG_arch_1 is used in 2 places:
> +	 * 1. for storage keys of hugetlb folios and KVM
> +	 * 2. As an indication that this small folio might be secure. This can
>  	 *    overindicate, e.g. we set the bit before calling
>  	 *    convert_to_secure.
> -	 * As secure pages are never huge, all 3 variants can co-exists.
> +	 * As secure pages are never large folios, both variants can co-exists.
>  	 */
>  	if (!test_bit(PG_arch_1, &folio->flags))
>  		return 0;