| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAL_JsqJM-DQvZ0fyJ17nY=vqtCRxyQwXGh6sbbAJ7rFjnAGrEA@mail.gmail.com> Date: Wed, 10 Apr 2024 13:11:09 -0500 From: Rob Herring <robh@...nel.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, Krzysztof Wilczyński <kw@...ux.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Hector Martin <marcan@...can.st>, Sven Peter <sven@...npeter.dev>, Alyssa Rosenzweig <alyssa@...enzweig.io>, Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Jim Quinlan <jim2101024@...il.com>, Nicolas Saenz Julienne <nsaenz@...nel.org>, Florian Fainelli <florian.fainelli@...adcom.com>, Will Deacon <will@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, Srikanth Thokala <srikanth.thokala@...el.com>, Ryder Lee <ryder.lee@...iatek.com>, Jianjun Wang <jianjun.wang@...iatek.com>, Sergio Paracuellos <sergio.paracuellos@...il.com>, Matthias Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Daire McNamara <daire.mcnamara@...rochip.com>, Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konrad.dybcio@...aro.org>, Marek Vasut <marek.vasut+renesas@...il.com>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, Shawn Lin <shawn.lin@...k-chips.com>, Heiko Stuebner <heiko@...ech.de>, Jingoo Han <jingoohan1@...il.com>, Gustavo Pimentel <gustavo.pimentel@...opsys.com>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Bharat Kumar Gogada <bharat.kumar.gogada@....com>, Michal Simek <michal.simek@....com>, Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, Neil Armstrong <neil.armstrong@...aro.org>, Mark Kettenis <kettenis@...nbsd.org>, Tom Joseph <tjoseph@...ence.com>, Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@...el.com>, Jiaxun Yang <jiaxun.yang@...goat.com>, Kishon Vijay Abraham I <kishon@...nel.org>, Thippeswamy Havalige <thippeswamy.havalige@....com>, linux-pci@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, linux-rpi-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org, linux-renesas-soc@...r.kernel.org, linux-rockchip@...ts.infradead.org Subject: Re: [PATCH 3/3] dt-bindings: PCI: host-bridges: switch from deprecated pci-bus.yaml On Wed, Apr 10, 2024 at 1:00 PM Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote: > > On 10/04/2024 19:48, Rob Herring wrote: > > On Sun, Apr 07, 2024 at 12:20:00PM +0200, Krzysztof Kozlowski wrote: > >> dtschema package with core schemas deprecated pci-bus.yaml schema in > >> favor of pci-host-bridge.yaml. Update all bindings to use the latter > >> one. > >> > >> The difference between pci-bus.yaml and pci-host-bridge.yaml is only in > >> lack of "reg" property defined by the latter, which should not have any > >> effect here, because all these bindings define the "reg". > >> > >> The change is therefore quite trivial, except mediatek,mt7621-pcie.yaml > >> binding which have children nodes being also host bridges, apparently. > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> > >> --- > >> Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/apple,pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/cdns-pcie-host.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/intel,ixp4xx-pci.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/loongson.yaml | 2 +- > >> .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 4 ++-- > >> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 2 +- > >> .../devicetree/bindings/pci/microchip,pcie-host.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/rcar-pci-host.yaml | 2 +- > >> .../devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 2 +- > >> .../devicetree/bindings/pci/rockchip,rk3399-pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/versatile.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml | 2 +- > >> 25 files changed, 26 insertions(+), 26 deletions(-) > > > > > >> diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml > >> index 61d027239910..5bbb4a3f3dbd 100644 > >> --- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml > >> +++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml > >> @@ -14,7 +14,7 @@ description: |+ > >> with 3 Root Ports. Each Root Port supports a Gen1 1-lane Link > >> > >> allOf: > >> - - $ref: /schemas/pci/pci-bus.yaml# > >> + - $ref: /schemas/pci/pci-host-bridge.yaml# > >> > >> properties: > >> compatible: > >> @@ -33,7 +33,7 @@ properties: > >> patternProperties: > >> '^pcie@[0-2],0$': > >> type: object > >> - $ref: /schemas/pci/pci-bus.yaml# > >> + $ref: /schemas/pci/pci-host-bridge.yaml# > > > > I think this one should be pci-pci-bridge.yaml instead since it says > > these are root ports and based on the unit-address here. > > I was thinking about this as well, but pci-pci-bridge.yaml defines > compatible which is not present here at all. Since you suggest pci-pci, > I'll go with this and make it a separate patch for easier review. This was my concern at first. It does define compatible, but it doesn't require it. So I think we are fine. Rob
Powered by blists - more mailing lists