linux-kernel - Re: [PATCH] soc: qcom: fix module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <689f6a74-185d-4f2f-8c31-e6502b7e6060@kernel.org>
Date: Wed, 10 Apr 2024 20:28:41 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bjorn Andersson <quic_bjorande@...cinc.com>,
 Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: fix module autoloading

On 10/04/2024 20:11, Bjorn Andersson wrote:
> On Wed, Apr 10, 2024 at 07:53:32PM +0200, Konrad Dybcio wrote:
>>
>>
>> On 4/10/24 18:40, Krzysztof Kozlowski wrote:
>>> Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded
>>> based on the alias from of_device_id table.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>>> ---
>>
>> These were omitted intentionally, as these are both debug drivers.
>>
> 
> Makes sense to me, could we have a comment added that clarifies this
> intention?
> 
>> Perhaps we could mkdir drivers/soc/qcom/debug to make this clearer
>>
> 
> Not sure if that is necessary, and IMO it wouldn't convey that
> MODULE_DEVICE_TABLE() was omitted intentionally.

I think this deserves a comment, so no one will be doing my same again
(it's part of bigger effort).

Best regards,
Krzysztof