linux-kernel - Re: [PATCH v2 4/4] dt-bindings: PCI: mediatek,mt7621-pcie: switch from deprecated pci-bus.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 10 Apr 2024 14:32:31 -0500
From: Rob Herring <robh@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: linux-rockchip@...ts.infradead.org, 
 Scott Branden <sbranden@...adcom.com>, 
 Thippeswamy Havalige <thippeswamy.havalige@....com>, 
 Sergio Paracuellos <sergio.paracuellos@...il.com>, 
 Will Deacon <will@...nel.org>, Sven Peter <sven@...npeter.dev>, 
 Heiko Stuebner <heiko@...ech.de>, Jiaxun Yang <jiaxun.yang@...goat.com>, 
 Florian Fainelli <florian.fainelli@...adcom.com>, 
 Linus Walleij <linus.walleij@...aro.org>, devicetree@...r.kernel.org, 
 Jim Quinlan <jim2101024@...il.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Bjorn Helgaas <bhelgaas@...gle.com>, linux-arm-kernel@...ts.infradead.org, 
 Bharat Kumar Gogada <bharat.kumar.gogada@....com>, asahi@...ts.linux.dev, 
 linux-arm-msm@...r.kernel.org, Hector Martin <marcan@...can.st>, 
 Alyssa Rosenzweig <alyssa@...enzweig.io>, 
 Matthias Brugger <matthias.bgg@...il.com>, 
 Krzysztof Wilczyński <kw@...ux.com>, 
 Lorenzo Pieralisi <lpieralisi@...nel.org>, 
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
 Mark Kettenis <kettenis@...nbsd.org>, 
 Geert Uytterhoeven <geert+renesas@...der.be>, 
 Tom Joseph <tjoseph@...ence.com>, linux-renesas-soc@...r.kernel.org, 
 Jianjun Wang <jianjun.wang@...iatek.com>, 
 Gustavo Pimentel <gustavo.pimentel@...opsys.com>, 
 Jingoo Han <jingoohan1@...il.com>, linux-pci@...r.kernel.org, 
 Conor Dooley <conor+dt@...nel.org>, linux-rpi-kernel@...ts.infradead.org, 
 linux-kernel@...r.kernel.org, 
 Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, 
 Michal Simek <michal.simek@....com>, 
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, 
 Nicolas Saenz Julienne <nsaenz@...nel.org>, Ray Jui <rjui@...adcom.com>, 
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
 Daire McNamara <daire.mcnamara@...rochip.com>, 
 Marek Vasut <marek.vasut+renesas@...il.com>, 
 linux-mediatek@...ts.infradead.org, 
 Konrad Dybcio <konrad.dybcio@...aro.org>, 
 Srikanth Thokala <srikanth.thokala@...el.com>, 
 Ryder Lee <ryder.lee@...iatek.com>, Bjorn Andersson <andersson@...nel.org>, 
 Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@...el.com>, 
 Kishon Vijay Abraham I <kishon@...nel.org>, 
 Magnus Damm <magnus.damm@...il.com>, 
 Neil Armstrong <neil.armstrong@...aro.org>, 
 Shawn Lin <shawn.lin@...k-chips.com>
Subject: Re: [PATCH v2 4/4] dt-bindings: PCI: mediatek,mt7621-pcie: switch
 from deprecated pci-bus.yaml


On Wed, 10 Apr 2024 20:15:21 +0200, Krzysztof Kozlowski wrote:
> dtschema package with core schemas deprecated pci-bus.yaml schema in
> favor of individual schemas per host, device and pci-pci.
> 
> Switch Mediatek MT7621 PCIe host bridge binding to this new schema.
> 
> This requires dtschema package newer than v2024.02 to work fully.
> v2024.02 will partially work: with a warning.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Important: v2024.03 (said dtschema newer than v2024.02) was not yet
> released, therefore this patch probably should wait a bit. Previous
> patches do not depend anyhow on future release, so they can be taken as
> is.
> 
> Changes in v2:
> 1. New patch
> 2. Split mediatek,mt7621-pcie to separate patch as it uses
>    pci-pci-bridge schema.
> ---
>  .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml         | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.example.dtb: pcie@...40000: pcie@0,0: Unevaluated properties are not allowed ('clocks', 'phy-names', 'phys', 'resets' were unexpected)
	from schema $id: http://devicetree.org/schemas/pci/mediatek,mt7621-pcie.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.example.dtb: pcie@...40000: pcie@1,0: Unevaluated properties are not allowed ('clocks', 'phy-names', 'phys', 'resets' were unexpected)
	from schema $id: http://devicetree.org/schemas/pci/mediatek,mt7621-pcie.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.example.dtb: pcie@...40000: pcie@2,0: Unevaluated properties are not allowed ('clocks', 'phy-names', 'phys', 'resets' were unexpected)
	from schema $id: http://devicetree.org/schemas/pci/mediatek,mt7621-pcie.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240410181521.269431-4-krzysztof.kozlowski@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.