linux-kernel - Re: [PATCH] md/raid5: fix deadlock that raid5d() wait for itself to clear MD_SB_CHANGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 10 Apr 2024 14:37:36 -0700
From: Song Liu <song@...nel.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: logang@...tatee.com, dan@...m.net, junxiao.bi@...cle.com, xni@...hat.com, 
	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org, yukuai3@...wei.com, 
	yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH] md/raid5: fix deadlock that raid5d() wait for itself to
 clear MD_SB_CHANGE_PENDING

On Fri, Mar 22, 2024 at 1:17 AM Yu Kuai <yukuai1@...weicloud.com> wrote:
[...]
>
> Refer to the implementation from raid1 and raid10, fix this problem by
> skipping issue IO if MD_SB_CHANGE_PENDING is still set after
> md_check_recovery(), daemon thread will be woken up when 'reconfig_mutex'
> is released. Meanwhile, the hang problem will be fixed as well.
>
> Fixes: 5e2cf333b7bd ("md/raid5: Wait for MD_SB_CHANGE_PENDING in raid5d")
> Reported-and-tested-by: Dan Moulding <dan@...m.net>
> Closes: https://lore.kernel.org/all/20240123005700.9302-1-dan@danm.net/
> Investigated-by: Junxiao Bi <junxiao.bi@...cle.com>
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>

Applied to md-6.10. Thanks!

Song