| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20240410-smatch-v1-3-785d009a852b@chromium.org> Date: Wed, 10 Apr 2024 21:54:40 +0000 From: Ricardo Ribalda <ribalda@...omium.org> To: Mauro Carvalho Chehab <mchehab@...nel.org>, Yasunari Takiguchi <Yasunari.Takiguchi@...y.com>, Jean-Christophe Trotin <jean-christophe.trotin@...s.st.com>, Lars-Peter Clausen <lars@...afoo.de>, Dmitry Torokhov <dmitry.torokhov@...il.com> Cc: Hans Verkuil <hverkuil-cisco@...all.nl>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, linux-input@...r.kernel.org, Ricardo Ribalda <ribalda@...omium.org> Subject: [PATCH 3/6] media: platform: sti: hva: clk_unprepare unconditionally hva->clk cannot be NULL at this point. Simplify the code and make smatch happy: drivers/media/platform/st/sti/hva/hva-hw.c:412 hva_hw_probe() warn: 'hva->clk' from clk_prepare() not released on lines: 412 Signed-off-by: Ricardo Ribalda <ribalda@...omium.org> --- drivers/media/platform/st/sti/hva/hva-hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/st/sti/hva/hva-hw.c b/drivers/media/platform/st/sti/hva/hva-hw.c index fe4ea2e7f37e3..fcb18fb52fdd7 100644 --- a/drivers/media/platform/st/sti/hva/hva-hw.c +++ b/drivers/media/platform/st/sti/hva/hva-hw.c @@ -406,8 +406,7 @@ int hva_hw_probe(struct platform_device *pdev, struct hva_dev *hva) err_disable: pm_runtime_disable(dev); err_clk: - if (hva->clk) - clk_unprepare(hva->clk); + clk_unprepare(hva->clk); return ret; } -- 2.44.0.478.gd926399ef9-goog
Powered by blists - more mailing lists