linux-kernel - Re: [PATCH] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 11 Apr 2024 00:06:33 +0200
From: "Noah Loomans" <noah@...hloomans.com>
To: "Guenter Roeck" <groeck@...gle.com>
Cc: "Bhanu Prakash Maiya" <bhanumaiya@...omium.org>, "Benson Leung"
 <bleung@...omium.org>, "Tzung-Bi Shih" <tzungbi@...nel.org>, "Guenter
 Roeck" <groeck@...omium.org>, "Robert Zieba" <robertzieba@...gle.com>,
 <chrome-platform@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
 <stable@...r.kernel.org>
Subject: Re: [PATCH] platform/chrome: cros_ec_uart: properly fix race
 condition

On 2024-04-10 at 21:48 UTC+02, Guenter Roeck wrote:
> On Wed, Apr 10, 2024 at 11:29 AM Noah Loomans <noah@...hloomans.com> wrote:
> > This is my first time contributing to Linux, I hope this is a good
> > patch. Feedback on how to improve is welcome!
>
> The commit message is a bit long, but the patch itself looks good to me.

Hmm yeah it's a bit on a long side. I'm not sure what could be removed
though, it all seems relevant for understanding the bug and the fix.

> Reviewed-by: Guenter Roeck <groeck@...omium.org>

Thanks!

-Noah