linux-kernel - Re: [PATCH v3 1/2] dt-bindings: dma: fsl-edma: remove 'clocks' from required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <680f8830-6cd8-433b-85b7-439070bc528f@linaro.org>
Date: Wed, 10 Apr 2024 08:30:25 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Frank Li <Frank.li@....com>
Cc: conor+dt@...nel.org, devicetree@...r.kernel.org,
 dmaengine@...r.kernel.org, imx@...ts.linux.dev,
 krzysztof.kozlowski+dt@...aro.org, linux-kernel@...r.kernel.org,
 peng.fan@....com, robh@...nel.org, vkoul@...nel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: dma: fsl-edma: remove 'clocks' from
 required

On 09/04/2024 23:09, Frank Li wrote:
> On Tue, Apr 09, 2024 at 10:02:32PM +0200, Krzysztof Kozlowski wrote:
>> On 09/04/2024 20:54, Frank Li wrote:
>>> fsl,imx8qm-adma and fsl,imx8qm-edma don't require 'clocks'. Remove it from
>>> required and add 'if' block for other compatible string to keep the same
>>> restrictions.
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> Signed-off-by: Frank Li <Frank.Li@....com>
>>> ---
>>>
>>> Notes:
>>>     Change from v2 to v3
>>>       - rebase to dmaengine/next
>>
>> This fails...
> 
> What's wrong? 
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git/log/?h=next
> 
>>
>>>
>>> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
>>> index 825f4715499e5..657a7d3ebf857 100644
>>> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
>>> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
>>> @@ -82,7 +82,6 @@ required:
>>>    - compatible
>>>    - reg
>>>    - interrupts
>>> -  - clocks
>>>    - dma-channels
>>>  
>>>  allOf:
>>> @@ -187,6 +186,22 @@ allOf:
>>>          "#dma-cells":
>>>            const: 3
>>>  
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +	  contains:
>>
>> It does not look like you tested the bindings, at least after quick
>> look. Please run `make dt_binding_check` (see
>> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>> Maybe you need to update your dtschema and yamllint.
> 
> Strange, Test passed
> 
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8  dt_binding_check DT_SCHEMA_FILES=fsl,edma.yaml
>   LINT    Documentation/devicetree/bindings
>   DTEX    Documentation/devicetree/bindings/dma/fsl,edma.example.dts
>   CHKDT   Documentation/devicetree/bindings/processed-schema.json
>   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>   DTC_CHK Documentation/devicetree/bindings/dma/fsl,edma.example.dtb

Nope, you tested other patch. Just look at your second patch for this.
When reviewer points to errors to your code, please investigate?

NAK, fix your patches.

Best regards,
Krzysztof