linux-kernel - Re: [PATCH v1] ACPI: bus: allow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240410074917.GX112498@black.fi.intel.com>
Date: Wed, 10 Apr 2024 10:49:17 +0300
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: Raag Jadav <raag.jadav@...el.com>
Cc: rafael@...nel.org, lenb@...nel.org, robert.moore@...el.com,
	andriy.shevchenko@...ux.intel.com,
	stanislaw.gruszka@...ux.intel.com, linux-acpi@...r.kernel.org,
	acpica-devel@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] ACPI: bus: allow _UID matching for integer zero

On Thu, Mar 28, 2024 at 09:25:40AM +0530, Raag Jadav wrote:
> Commit b2b32a173881 ("ACPI: bus: update acpi_dev_hid_uid_match() to
> support multiple types") added _UID matching support for both integer
> and string types, which satisfies NULL @uid2 argument for string types
> using inversion, but this logic prevents _UID comparision in case the
                                                ^^^^^^^^^^^

Typo: comparison

> argument is integer 0, which may result in false positives.
> 
> Fix this using _Generic(), which will allow NULL @uid2 argument for
> string types as well as _UID matching for all possible integer values.
> 
> Fixes: b2b32a173881 ("ACPI: bus: update acpi_dev_hid_uid_match() to support multiple types")
> Signed-off-by: Raag Jadav <raag.jadav@...el.com>

Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>