linux-kernel - Re: [PATCH v4 1/9] mm/ksm: add ksm_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 10 Apr 2024 10:34:06 +0200
From: David Hildenbrand <david@...hat.com>
To: alexs@...nel.org, Andrew Morton <akpm@...ux-foundation.org>,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Cc: Izik Eidus <izik.eidus@...ellosystems.com>,
 Matthew Wilcox <willy@...radead.org>, Andrea Arcangeli
 <aarcange@...hat.com>, Hugh Dickins <hughd@...gle.com>,
 Chris Wright <chrisw@...s-sol.org>
Subject: Re: [PATCH v4 1/9] mm/ksm: add ksm_get_folio

On 09.04.24 11:28, alexs@...nel.org wrote:
> From: "Alex Shi (tencent)" <alexs@...nel.org>
> 
> The ksm only contains single pages, so we could add a new func
> ksm_get_folio for get_ksm_page to use folio instead of pages to save a
> couple of compound_head calls.
> 
> After all caller replaced, get_ksm_page will be removed.
> 
> Signed-off-by: Alex Shi (tencent) <alexs@...nel.org>
> To: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Izik Eidus <izik.eidus@...ellosystems.com>
> Cc: Matthew Wilcox <willy@...radead.org>
> Cc: Andrea Arcangeli <aarcange@...hat.com>
> Cc: Hugh Dickins <hughd@...gle.com>
> Cc: Chris Wright <chrisw@...s-sol.org>
> Reviewed-by: David Hildenbrand <david@...hat.com>
> ---
>   mm/ksm.c | 40 ++++++++++++++++++++++++----------------
>   1 file changed, 24 insertions(+), 16 deletions(-)
> 
> diff --git a/mm/ksm.c b/mm/ksm.c
> index 8c001819cf10..ac080235b002 100644
> --- a/mm/ksm.c
> +++ b/mm/ksm.c
> @@ -915,10 +915,10 @@ enum get_ksm_page_flags {
>    * a page to put something that might look like our key in page->mapping.
>    * is on its way to being freed; but it is an anomaly to bear in mind.
>    */
> -static struct page *get_ksm_page(struct ksm_stable_node *stable_node,
> +static struct folio *ksm_get_folio(struct ksm_stable_node *stable_node,

Just realized that you should adjust the function name in the comment 
above this function in this patch.

-- 
Cheers,

David / dhildenb