linux-kernel - Re: [PATCH] riscv: dts: sophgo: add initial Milk-V Duo S board device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <IA1PR20MB4953CA04D33EA0C7902DFA3ABB062@IA1PR20MB4953.namprd20.prod.outlook.com>
Date: Wed, 10 Apr 2024 09:24:40 +0800
From: Inochi Amaoto <inochiama@...look.com>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: Michael Opdenacker <michael.opdenacker@...tlin.com>, 
	Inochi Amaoto <inochiama@...look.com>, Conor Dooley <conor@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Chen Wang <unicorn_wang@...look.com>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, devicetree@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: dts: sophgo: add initial Milk-V Duo S board
 device tree

On Tue, Apr 09, 2024 at 03:08:17PM +0200, Michael Opdenacker wrote:
> Hi Inochi
> 
> On 4/9/24 at 14:27, Inochi Amaoto wrote:
> > On Tue, Apr 09, 2024 at 01:13:32PM +0100, Conor Dooley wrote:
> > > On Tue, Apr 09, 2024 at 03:17:35PM +0800, Inochi Amaoto wrote:
> > > > On Tue, Apr 09, 2024 at 08:45:04AM +0200, michael.opdenacker@...tlin.com wrote:
> > > > > From: Michael Opdenacker <michael.opdenacker@...tlin.com>
> > > > > 
> > > > > This adds initial support for the Milk-V Duo S board
> > > > > (https://milkv.io/duo-s), enabling the serial port and
> > > > > read-only SD card support, allowing to boot Linux to the
> > > > > command line.
> > > > > 
> > > > Hi Michael,
> > > > 
> > > > I think your patch losts the board binding and have wrong compatiable.
> > > > Also, the SD can have rw support with proper property. See link [1]
> > > > (need 'disable-wp').
> > > [1] doesn't go anywhere useful.
> > > 
> > This is my fault, I copied the wrong url. The right patch is
> > https://lore.kernel.org/r/20240217144826.3944-1-jszhang@kernel.org.
> 
> 
> No problem, I found out.
> I confirm that using the "disable-wp;" property does the trick to make the
> MMC writable.
> 
> However, it wasn't mentioned in the above URL...
> 
> By the way, do I really need those under &sdhci0?
> 
> + bus-width = <4>; + no-1-8-v; + no-mmc; + no-sdio;
> 
> My board looks happy so far without them ;-)

FYI, Jisheng. Could you share some suggestions?

> Thanks again for your help
> Cheers
> Michael.
> 
> -- 
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>