linux-kernel - Re: [PATCH] drm: xlnx: db: fix a memory leak in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b4f1714-2c63-4cc5-9288-f419512bf3d4@ideasonboard.com>
Date: Wed, 10 Apr 2024 14:11:23 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Dan Carpenter <dan.carpenter@...aro.org>,
 Rohit Visavalia <rohit.visavalia@....com>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Michal Simek <michal.simek@....com>, Vishal Sagar <vishal.sagar@....com>,
 dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drm: xlnx: db: fix a memory leak in probe

On 04/04/2024 10:32, Dan Carpenter wrote:
> Free "dp" before returning.
> 
> Fixes: be318d01a903 ("drm: xlnx: dp: Reset DisplayPort IP")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>   drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index 5a40aa1d4283..8a15d18a65a6 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -1716,7 +1716,7 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub)
>   
>   	ret = zynqmp_dp_reset(dp, true);
>   	if (ret < 0)
> -		return ret;
> +		goto err_free;
>   
>   	ret = zynqmp_dp_reset(dp, false);
>   	if (ret < 0)

Thanks, applying to drm-misc-next.

  Tomi