linux-kernel - Re: [PATCH] drm/omap: dmm_tiler: drop driver owner assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <37a20f0c-3911-4fa5-a5be-88e1d7fe4c50@ideasonboard.com>
Date: Wed, 10 Apr 2024 14:17:27 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/omap: dmm_tiler: drop driver owner assignment

On 30/03/2024 22:28, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.  Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 9753c1e1f994..1aca3060333e 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -1212,7 +1212,6 @@ struct platform_driver omap_dmm_driver = {
>   	.probe = omap_dmm_probe,
>   	.remove_new = omap_dmm_remove,
>   	.driver = {
> -		.owner = THIS_MODULE,
>   		.name = DMM_DRIVER_NAME,
>   		.of_match_table = of_match_ptr(dmm_of_match),
>   		.pm = &omap_dmm_pm_ops,

Thanks, applying to drm-misc-next.

  Tomi