linux-kernel - Re: [PATCH] drm: tilcdc: don't use devm_pinctrl_get_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56a2c5a4-4486-4274-8f3a-6c4e8ffce116@ideasonboard.com>
Date: Wed, 10 Apr 2024 14:29:51 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
 linux-renesas-soc@...r.kernel.org
Cc: Jyri Sarha <jyri.sarha@....fi>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: tilcdc: don't use devm_pinctrl_get_select_default()
 in probe

On 22/09/2023 10:37, Wolfram Sang wrote:
> Since commit ab78029ecc34 ("drivers/pinctrl: grab default handles from
> device core"), we can rely on device core for setting the default pins.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>   drivers/gpu/drm/tilcdc/tilcdc_panel.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 9aefd010acde..68093d6b6b16 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -6,7 +6,6 @@
>   
>   #include <linux/backlight.h>
>   #include <linux/gpio/consumer.h>
> -#include <linux/pinctrl/consumer.h>
>   #include <linux/platform_device.h>
>   
>   #include <video/display_timing.h>
> @@ -308,7 +307,6 @@ static int panel_probe(struct platform_device *pdev)
>   	struct backlight_device *backlight;
>   	struct panel_module *panel_mod;
>   	struct tilcdc_module *mod;
> -	struct pinctrl *pinctrl;
>   	int ret;
>   
>   	/* bail out early if no DT data: */
> @@ -342,10 +340,6 @@ static int panel_probe(struct platform_device *pdev)
>   
>   	tilcdc_module_init(mod, "panel", &panel_module_ops);
>   
> -	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> -	if (IS_ERR(pinctrl))
> -		dev_warn(&pdev->dev, "pins are not configured\n");
> -
>   	panel_mod->timings = of_get_display_timings(node);
>   	if (!panel_mod->timings) {
>   		dev_err(&pdev->dev, "could not get panel timings\n");

Thanks, applying to drm-misc-next.

  Tomi