[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240410121627.GA4069350-robh@kernel.org>
Date: Wed, 10 Apr 2024 07:16:27 -0500
From: Rob Herring <robh@...nel.org>
To: Yoshinori Sato <ysato@...rs.sourceforge.jp>
Cc: linux-sh@...r.kernel.org, Damien Le Moal <dlemoal@...nel.org>,
Niklas Cassel <cassel@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
Thomas Gleixner <tglx@...utronix.de>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof Wilczyński <kw@...ux.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jirislaby@...nel.org>,
Magnus Damm <magnus.damm@...il.com>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Rich Felker <dalias@...c.org>,
John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
Lee Jones <lee@...nel.org>, Helge Deller <deller@....de>,
Heiko Stuebner <heiko.stuebner@...rry.de>,
Shawn Guo <shawnguo@...nel.org>, Sebastian Reichel <sre@...nel.org>,
Chris Morgan <macromorgan@...mail.com>,
Linus Walleij <linus.walleij@...aro.org>,
Arnd Bergmann <arnd@...db.de>, David Rientjes <rientjes@...gle.com>,
Hyeonggon Yoo <42.hyeyoo@...il.com>,
Vlastimil Babka <vbabka@...e.cz>, Baoquan He <bhe@...hat.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Guenter Roeck <linux@...ck-us.net>,
Kefeng Wang <wangkefeng.wang@...wei.com>,
Stephen Rothwell <sfr@...b.auug.org.au>,
Javier Martinez Canillas <javierm@...hat.com>,
Guo Ren <guoren@...nel.org>, Azeem Shaikh <azeemshaikh38@...il.com>,
Max Filippov <jcmvbkbc@...il.com>, Jonathan Corbet <corbet@....net>,
Jacky Huang <ychuang3@...oton.com>,
Herve Codina <herve.codina@...tlin.com>,
Manikanta Guntupalli <manikanta.guntupalli@....com>,
Anup Patel <apatel@...tanamicro.com>,
Biju Das <biju.das.jz@...renesas.com>,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
Sam Ravnborg <sam@...nborg.org>,
Sergey Shtylyov <s.shtylyov@....ru>,
Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
linux-ide@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
linux-clk@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-pci@...r.kernel.org, linux-serial@...r.kernel.org,
linux-fbdev@...r.kernel.org
Subject: Re: [RESEND v7 12/37] dt-bindings: pci: pci-sh7751: Add SH7751 PCI
On Thu, Apr 04, 2024 at 02:14:23PM +0900, Yoshinori Sato wrote:
> Renesas SH7751 PCI Controller json-schema.
>
> Signed-off-by: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> ---
> .../bindings/pci/renesas,sh7751-pci.yaml | 89 +++++++++++++++++++
> 1 file changed, 89 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/renesas,sh7751-pci.yaml
>
> diff --git a/Documentation/devicetree/bindings/pci/renesas,sh7751-pci.yaml b/Documentation/devicetree/bindings/pci/renesas,sh7751-pci.yaml
> new file mode 100644
> index 000000000000..115c2bb67339
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pci/renesas,sh7751-pci.yaml
> @@ -0,0 +1,89 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pci/renesas,sh7751-pci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas SH7751 PCI Host controller
> +
> +maintainers:
> + - Yoshinori Sato <ysato@...rs.sourceforge.jp>
> +
> +allOf:
> + - $ref: /schemas/pci/pci-bus.yaml#
> +
> +properties:
> + compatible:
> + const: renesas,sh7751-pci
> +
> + reg:
> + minItems: 2
> + maxItems: 2
> +
> + reg-names:
> + items:
> + - const: PCI Controller
> + - const: Bus State Controller
> +
> + "#interrupt-cells":
> + const: 1
> +
> + "#address-cells":
> + const: 3
> +
> + "#size-cells":
> + const: 2
> +
> + ranges: true
> +
> + dma-ranges: true
All 5 of these are defined in pci-bus-common.yaml, so you can drop them.
> +
> + interrupt-controller: true
> +
> + renesas,bus-arbit-round-robin:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: |
Don't need '|'.
> + Set DMA bus arbitration to round robin.
> +
> +required:
> + - compatible
> + - reg
> + - "#interrupt-cells"
> + - "#address-cells"
> + - "#size-cells"
> + - ranges
These 3 are already required, so drop.
> + - interrupt-map
> + - interrupt-map-mask
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + pci@...00000 {
> + compatible = "renesas,sh7751-pci";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + #interrupt-cells = <1>;
> + interrupt-controller;
> + device_type = "pci";
> + bus-range = <0 0>;
> + ranges = <0x02000000 0 0xfd000000 0xfd000000 0 0x01000000>,
> + <0x01000000 0 0x00000000 0xfe240000 0 0x00040000>;
> + dma-ranges = <0x02000000 0 0xc000000 0x0c000000 0 0x04000000>;
> + reg = <0xfe200000 0x0400>,
> + <0xff800000 0x0100>;
> + interrupt-map = <0x0000 0 0 1 &julianintc 5 IRQ_TYPE_LEVEL_LOW>,
> + <0x0000 0 0 2 &julianintc 6 IRQ_TYPE_LEVEL_LOW>,
> + <0x0000 0 0 3 &julianintc 7 IRQ_TYPE_LEVEL_LOW>,
> + <0x0000 0 0 4 &julianintc 8 IRQ_TYPE_LEVEL_LOW>,
> + <0x0800 0 0 1 &julianintc 6 IRQ_TYPE_LEVEL_LOW>,
> + <0x0800 0 0 2 &julianintc 7 IRQ_TYPE_LEVEL_LOW>,
> + <0x0800 0 0 3 &julianintc 8 IRQ_TYPE_LEVEL_LOW>,
> + <0x0800 0 0 4 &julianintc 5 IRQ_TYPE_LEVEL_LOW>,
> + <0x1000 0 0 1 &julianintc 7 IRQ_TYPE_LEVEL_LOW>,
> + <0x1000 0 0 2 &julianintc 8 IRQ_TYPE_LEVEL_LOW>,
> + <0x1000 0 0 3 &julianintc 5 IRQ_TYPE_LEVEL_LOW>,
> + <0x1000 0 0 4 &julianintc 6 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-map-mask = <0x1800 0 0 7>;
> + };
> --
> 2.39.2
>
Powered by blists - more mailing lists