linux-kernel - Re: [PATCH net-next v10 07/13] net: Add struct kernel_ethtool_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 10 Apr 2024 15:54:12 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Jakub Kicinski <kuba@...nel.org>, Florian Fainelli
 <florian.fainelli@...adcom.com>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn <andrew@...n.ch>,
 Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, Radu Pirea
 <radu-nicolae.pirea@....nxp.com>, Jay Vosburgh <j.vosburgh@...il.com>, Andy
 Gospodarek <andy@...yhouse.net>, Nicolas Ferre
 <nicolas.ferre@...rochip.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>, Jonathan Corbet
 <corbet@....net>, Horatiu Vultur <horatiu.vultur@...rochip.com>,
 UNGLinuxDriver@...rochip.com, Simon Horman <horms@...nel.org>, Vladimir
 Oltean <vladimir.oltean@....com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, Maxime Chevallier
 <maxime.chevallier@...tlin.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>,
 Alexandra Winter <wintera@...ux.ibm.com>
Subject: Re: [PATCH net-next v10 07/13] net: Add struct
 kernel_ethtool_ts_info

On Wed, 10 Apr 2024 11:04:36 +0100
"Russell King (Oracle)" <linux@...linux.org.uk> wrote:

> On Wed, Apr 10, 2024 at 10:12:00AM +0200, Kory Maincent wrote:
> > On Tue, 9 Apr 2024 18:27:25 -0700
> > Jakub Kicinski <kuba@...nel.org> wrote:
> >   
> > > On Tue, 09 Apr 2024 10:26:29 +0200 Kory Maincent wrote:  
> > > > In prevision to add new UAPI for hwtstamp we will be limited to the
> > > > struct ethtool_ts_info that is currently passed in fixed binary format
> > > > through the ETHTOOL_GET_TS_INFO ethtool ioctl. It would be good if new
> > > > kernel code already started operating on an extensible kernel variant
> > > > of that structure, similar in concept to struct kernel_hwtstamp_config
> > > > vs struct hwtstamp_config.
> > > > 
> > > > Since struct ethtool_ts_info is in include/uapi/linux/ethtool.h, here
> > > > we introduce the kernel-only structure in include/linux/ethtool.h.
> > > > The manual copy is then made in the function called by
> > > > ETHTOOL_GET_TS_INFO. 
> > > 
> > > This one now conflicts :(
> > > 
> > > Applying: net: Add struct kernel_ethtool_ts_info
> > > error: sha1 information is lacking or useless
> > > (drivers/net/phy/marvell_ptp.c). error: could not build fake ancestor  
> > 
> > gnn patching my out of tree patch in the series! Sorry for that.  
> 
> Given that this path corresponds to the driver I wrote, do I assume
> that you've picked up my work on PTP support for Marvell PHYs? You
> should be aware that I still have the patches out of tree but it's
> been pointless me reposting it until the issue of which PTP gets
> used has been solved. (Publishing will just increase the pressure
> to merge it without the PTP problems being solved, and thus break
> Marvell PP2 PTP.)

Yes I did with few fixes and I know you don't want to post the patches until
setting which PTP gets used has been solved. As you can see this is one of the
subject of this series. About it, could you review this series? This would help
a lot and you will be able to post again your Marvell PTP patches if its get
merged.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com