linux-kernel - Re: [PATCH v5 0/2] Samsung Galaxy Z Fold5 initial support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171284284762.3456856.9357372275932519811.robh@kernel.org>
Date: Thu, 11 Apr 2024 08:42:26 -0500
From: Rob Herring <robh@...nel.org>
To: Alexandru Marc Serdeliuc <serdeliuk@...oo.com>
Cc: linux-kernel@...r.kernel.org, Konrad Dybcio <konrad.dybcio@...aro.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
 devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
 Bjorn Andersson <andersson@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v5 0/2] Samsung Galaxy Z Fold5 initial support


On Wed, 10 Apr 2024 23:28:32 +0200, Alexandru Marc Serdeliuc wrote:
> This documents and add intial dts support for Samsung Galaxy Z Fold5 (samsung,q5q)
> which is a foldable phone by Samsung based on the sm8550 SoC.
> 
> ChangeLog
> 
> - v5
>   . Added ChangeLog
>   . Added missing Acked-by tags in their respective section in ChangeLog
> 
> - v4
>   . removed a spurious new line
>   . removed pcie_1_phy_aux_clk as requested
>   . removed secondary pcie1 which does not exists on the device
>   . changed firmware extension from .mbn to .mdt
>   . added missing reserved memory regions required by firmware to properly load
> 
> - v3
>   . added b4 version 3
>   . removed address and size cells in device description
>   Acked-by: Rob Herring <robh@...nel.org>
> 
> - v2
>   . added both but added an extra v2 in the subject line instead to b4 subject header, was requested to send the patch again, along with following mods:
>   . removed whole bootargs line
>   . fixed underscores in reserved memory by removing all reserved memory regions
>   . added missing idetation to  spash_screen remark
>   . validated the dts with "dtbs_check"
>   . removed all comments at the end of nodes
>   . moved status of the node at the end of the node
>   . reversed pin control name with control numbers
>   . ordered the  nodes alphabetically
> 
> - v1
>   . The initial request was split in two patches sent due to the following checkpatch warning, was requested to re send them together:
>     WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>   Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@...oo.com>
> ---
> Alexandru Marc Serdeliuc (2):
>       dt-bindings: arm: qcom: Document the Samsung Galaxy Z Fold5
>       arm64: dts: qcom: sm8550: Add support for Samsung Galaxy Z Fold5
> 
>  Documentation/devicetree/bindings/arm/qcom.yaml |   1 +
>  arch/arm64/boot/dts/qcom/Makefile               |   1 +
>  arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts | 593 ++++++++++++++++++++++++
>  3 files changed, 595 insertions(+)
> ---
> base-commit: 2c71fdf02a95b3dd425b42f28fd47fb2b1d22702
> change-id: 20240410-samsung-galaxy-zfold5-q5q-d31cdeeac09f
> 
> Best regards,
> --
> Alexandru Marc Serdeliuc <serdeliuk@...oo.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/sm8550-samsung-q5q.dtb' for 20240410-samsung-galaxy-zfold5-q5q-v5-0-9311ee9a55f7@...oo.com:

arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dtb: pcie-1-phy-aux-clk: 'clock-frequency' is a required property
	from schema $id: http://devicetree.org/schemas/clock/fixed-clock.yaml#
arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dtb: phy@...e000: clock-output-names: ['pcie1_pipe_clk'] is too short
	from schema $id: http://devicetree.org/schemas/phy/qcom,sc8280xp-qmp-pcie-phy.yaml#
arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dtb: phy@...e000: #clock-cells:0:0: 1 was expected
	from schema $id: http://devicetree.org/schemas/phy/qcom,sc8280xp-qmp-pcie-phy.yaml#