linux-kernel - Re: [PATCH v1 06/31] x86/resctrl: Export resctrl fs's init function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZhfwUHHmOtXZqX1S@e133380.arm.com>
Date: Thu, 11 Apr 2024 15:14:40 +0100
From: Dave Martin <Dave.Martin@....com>
To: "Shaopeng Tan (Fujitsu)" <tan.shaopeng@...itsu.com>
Cc: 'James Morse' <james.morse@....com>, "x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Reinette Chatre <reinette.chatre@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	H Peter Anvin <hpa@...or.com>, Babu Moger <Babu.Moger@....com>,
	"shameerali.kolothum.thodi@...wei.com" <shameerali.kolothum.thodi@...wei.com>,
	D Scott Phillips OS <scott@...amperecomputing.com>,
	"carl@...amperecomputing.com" <carl@...amperecomputing.com>,
	"lcherian@...vell.com" <lcherian@...vell.com>,
	"bobo.shaobowang@...wei.com" <bobo.shaobowang@...wei.com>,
	"baolin.wang@...ux.alibaba.com" <baolin.wang@...ux.alibaba.com>,
	Jamie Iles <quic_jiles@...cinc.com>,
	Xin Hao <xhao@...ux.alibaba.com>,
	"peternewman@...gle.com" <peternewman@...gle.com>,
	"dfustini@...libre.com" <dfustini@...libre.com>,
	"amitsinght@...vell.com" <amitsinght@...vell.com>,
	David Hildenbrand <david@...hat.com>,
	Rex Nie <rex.nie@...uarmicro.com>
Subject: Re: [PATCH v1 06/31] x86/resctrl: Export resctrl fs's init function

On Wed, Apr 03, 2024 at 07:51:54AM +0000, Shaopeng Tan (Fujitsu) wrote:
> Hello James,
> 
> > rdtgroup_init() needs exporting so that arch code can call it once it lives in core
> > code. As this is one of the few functions we export, rename it to have the resctrl
> > in the name. The same goes for the exit call.
> > 
> > x86's arch code init functions for RDT are renamed to have an arch prefix to
> > make it clear these are part of the architecture code.
> > 
> > Signed-off-by: James Morse <james.morse@....com>
> > ---
> >  arch/x86/kernel/cpu/resctrl/core.c     | 12 ++++++------
> >  arch/x86/kernel/cpu/resctrl/internal.h |  3 ---
> > arch/x86/kernel/cpu/resctrl/rdtgroup.c |  8 ++++----
> >  include/linux/resctrl.h                |  3 +++
> >  4 files changed, 13 insertions(+), 13 deletions(-)
> 
> /fs/resctrl/monitor.c
> 746          * RESCTRL_RESERVED_CLOSID and RESCTRL_RESERVED_RMID are special and
> 747          * are always allocated. These are used for the rdtgroup_default
> 748          * control group, which will be setup later in rdtgroup_init(). 
> "rdtgroup_init()" is still in the comments.
> 
> 
> Best regards,
> Shaopeng TAN
> 

[...]

Noted for James' attention, thanks.

Cheers
---Dave