linux-kernel - Re: [PATCH v1 14/31] x86/resctrl: Export the is_mbm_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zhfws5KVuCPXy9V8@e133380.arm.com>
Date: Thu, 11 Apr 2024 15:16:19 +0100
From: Dave Martin <Dave.Martin@....com>
To: Reinette Chatre <reinette.chatre@...el.com>
Cc: James Morse <james.morse@....com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Fenghua Yu <fenghua.yu@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	H Peter Anvin <hpa@...or.com>, Babu Moger <Babu.Moger@....com>,
	shameerali.kolothum.thodi@...wei.com,
	D Scott Phillips OS <scott@...amperecomputing.com>,
	carl@...amperecomputing.com, lcherian@...vell.com,
	bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
	baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
	Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
	dfustini@...libre.com, amitsinght@...vell.com,
	David Hildenbrand <david@...hat.com>,
	Rex Nie <rex.nie@...uarmicro.com>
Subject: Re: [PATCH v1 14/31] x86/resctrl: Export the is_mbm_*_enabled()
 helpers to asm/resctrl.h

On Mon, Apr 08, 2024 at 08:20:12PM -0700, Reinette Chatre wrote:
> Hi James,
> 
> On 3/21/2024 9:50 AM, James Morse wrote:
> > The architecture specific parts of resctrl have helpers to hide accesses
> > to the rdt_mon_features bitmap.
> > 
> > Once the filesystem parts of resctrl are moved, these can no longer live
> > in internal.h. Once these are exposed to the wider kernel, they should
> > have a 'resctrl_arch_' prefix, to fit the rest of the arch<->fs interface.
> > 
> > Move and rename the helpers that touch rdt_mon_features directly.
> > is_mbm_event() and is_mbm_enabled() are only called from rdtgroup.c,
> > so can be moved into that file.
> > 
> > Signed-off-by: James Morse <james.morse@....com>
> > ---
> >  arch/x86/include/asm/resctrl.h         | 17 +++++++++++
> >  arch/x86/kernel/cpu/resctrl/core.c     |  4 +--
> >  arch/x86/kernel/cpu/resctrl/internal.h | 27 -----------------
> >  arch/x86/kernel/cpu/resctrl/monitor.c  | 18 ++++++------
> >  arch/x86/kernel/cpu/resctrl/rdtgroup.c | 40 +++++++++++++++++---------
> >  5 files changed, 54 insertions(+), 52 deletions(-)
> > 
> > diff --git a/arch/x86/include/asm/resctrl.h b/arch/x86/include/asm/resctrl.h
> > index 5f6a5375bb4a..50407e83d0ca 100644
> > --- a/arch/x86/include/asm/resctrl.h
> > +++ b/arch/x86/include/asm/resctrl.h
> > @@ -7,6 +7,7 @@
> >  #include <linux/jump_label.h>
> >  #include <linux/percpu.h>
> >  #include <linux/sched.h>
> > +#include <linux/resctrl_types.h>
> >  
> 
> Can this be alphabetical?

I'd guess so, looking at it.

Noted.

Cheers
---Dave